Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump up auxiliary coverage #2570

Merged
merged 40 commits into from
Mar 5, 2020
Merged

Conversation

RMeli
Copy link
Member

@RMeli RMeli commented Feb 29, 2020

Start addressing #597; it would be nice to have a higher coverage (see #2410, #2453). This PR starts to bump up test coverage for auxiliary by testing raised exceptions.

Changes made in this Pull Request:

  • Added tests for exceptions in auxiliary

PR Checklist

  • Tests?
  • Issue raised/referenced?

RMeli and others added 30 commits August 7, 2019 18:41
@codecov
Copy link

codecov bot commented Feb 29, 2020

Codecov Report

Merging #2570 into develop will increase coverage by 0.09%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #2570      +/-   ##
===========================================
+ Coverage    90.68%   90.78%   +0.09%     
===========================================
  Files          169      169              
  Lines        22833    22832       -1     
  Branches      2940     2940              
===========================================
+ Hits         20707    20728      +21     
+ Misses        1540     1525      -15     
+ Partials       586      579       -7
Impacted Files Coverage Δ
package/MDAnalysis/auxiliary/XVG.py 94.69% <ø> (+6.97%) ⬆️
auxiliary/base.py 91.29% <0%> (+0.96%) ⬆️
package/MDAnalysis/auxiliary/base.py 88.92% <0%> (+1.62%) ⬆️
package/MDAnalysis/auxiliary/core.py 95.65% <0%> (+26.08%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bc2f1a5...952a3e2. Read the comment docs.

@RMeli
Copy link
Member Author

RMeli commented Mar 2, 2020

For some reason I can't suggest a reviewer, but I think @fiona-naughton will be the most appropriate. :)

@RMeli RMeli changed the title [WIP] Bump up auxiliary coverage Bump up auxiliary coverage Mar 2, 2020
@orbeckst orbeckst requested a review from fiona-naughton March 3, 2020 00:49
@orbeckst
Copy link
Member

orbeckst commented Mar 3, 2020

I requested @fiona-naughton for you.

@fiona-naughton
Copy link
Contributor

Looks good to me! (other than maybe a few extraneous blank lines if we care about keeping the style consistent)

@RMeli
Copy link
Member Author

RMeli commented Mar 4, 2020

Thanks for the comments @fiona-naughton; the blank lines are flake8's fault! ;) I can revert them if preferred, but they should be conformant with PEP8.

@fiona-naughton
Copy link
Contributor

Ah, fair enough - should be fine, then!

@orbeckst
Copy link
Member

orbeckst commented Mar 5, 2020

@fiona-naughton thanks.

In the future, can you please leave your reviews via the code reviews (click on files changed unless there's a button with your name on it when you've been requested)(and click approve/request changes to make it clearer that you reviewed the code and had an opinion? That's going to be the pattern for GSoC so I'd like to get everyone used to it.

Copy link
Member

@orbeckst orbeckst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Thanks @fiona-naughton for the review!

@orbeckst orbeckst merged commit 0b20ae8 into MDAnalysis:develop Mar 5, 2020
@RMeli RMeli deleted the feat/auxreader-cov branch March 5, 2020 10:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants