-
Notifications
You must be signed in to change notification settings - Fork 661
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump up auxiliary coverage #2570
Conversation
Codecov Report
@@ Coverage Diff @@
## develop #2570 +/- ##
===========================================
+ Coverage 90.68% 90.78% +0.09%
===========================================
Files 169 169
Lines 22833 22832 -1
Branches 2940 2940
===========================================
+ Hits 20707 20728 +21
+ Misses 1540 1525 -15
+ Partials 586 579 -7
Continue to review full report at Codecov.
|
For some reason I can't suggest a reviewer, but I think @fiona-naughton will be the most appropriate. :) |
I requested @fiona-naughton for you. |
Looks good to me! (other than maybe a few extraneous blank lines if we care about keeping the style consistent) |
Thanks for the comments @fiona-naughton; the blank lines are |
Ah, fair enough - should be fine, then! |
@fiona-naughton thanks. In the future, can you please leave your reviews via the code reviews (click on files changed unless there's a button with your name on it when you've been requested)(and click approve/request changes to make it clearer that you reviewed the code and had an opinion? That's going to be the pattern for GSoC so I'd like to get everyone used to it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Thanks @fiona-naughton for the review!
Start addressing #597; it would be nice to have a higher coverage (see #2410, #2453). This PR starts to bump up test coverage for
auxiliary
by testing raised exceptions.Changes made in this Pull Request:
auxiliary
PR Checklist