-
Notifications
You must be signed in to change notification settings - Fork 667
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] Cythonizes GROParser & GROReader very minimally #2227
Closed
+49
−21
Closed
Changes from 1 commit
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
a1a2bff
GRO_cyth
fenilsuchak e3d3f9f
fix_build
fenilsuchak 4000073
fixed_build_again
fenilsuchak 7fe641f
typed memoryview added
fenilsuchak a06480c
long to long long
fenilsuchak 3c8ce23
removed_python_intermediate
fenilsuchak 35c99e4
long to int & remove cimport np
fenilsuchak 1669bbc
cython_gro_reader
fenilsuchak a41a5c1
fixed GROReader not getting added to _READERS registry
richardjgowers File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
cython_gro_reader
commit 1669bbc5060b9b298b0eb9bc81b6fbef3bed8e81
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
these decorators aren't doing what you are expecting here, they won't apply to the whole file. I think they're probably just modifying the Timestep object.
You probably need to decorate the class method directly