Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Start 0.19.1 #2096

Merged
merged 3 commits into from
Oct 9, 2018
Merged

Start 0.19.1 #2096

merged 3 commits into from
Oct 9, 2018

Conversation

richardjgowers
Copy link
Member

Wait for #2095 to merge before accepting this

@codecov
Copy link

codecov bot commented Oct 9, 2018

Codecov Report

Merging #2096 into develop will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff            @@
##           develop    #2096   +/-   ##
========================================
  Coverage    89.41%   89.41%           
========================================
  Files          157      157           
  Lines        18765    18765           
  Branches      2711     2711           
========================================
  Hits         16778    16778           
  Misses        1382     1382           
  Partials       605      605
Impacted Files Coverage Δ
package/MDAnalysis/core/groups.py 97.36% <ø> (ø) ⬆️
package/MDAnalysis/coordinates/LAMMPS.py 89.31% <ø> (ø) ⬆️
package/MDAnalysis/coordinates/memory.py 96.02% <ø> (ø) ⬆️
package/MDAnalysis/topology/TOPParser.py 100% <ø> (ø) ⬆️
package/MDAnalysis/analysis/dihedrals.py 96.52% <ø> (ø) ⬆️
package/MDAnalysis/topology/LAMMPSParser.py 95.33% <ø> (ø) ⬆️
package/MDAnalysis/coordinates/PDB.py 88.88% <ø> (ø) ⬆️
package/MDAnalysis/analysis/density.py 64.94% <ø> (ø) ⬆️
package/MDAnalysis/core/topologyobjects.py 98.41% <ø> (ø) ⬆️
package/MDAnalysis/version.py 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 97db6d1...54f5ce5. Read the comment docs.

Copy link
Member

@orbeckst orbeckst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

(I was looking for these commits on develop... then I checked this PR)

@orbeckst
Copy link
Member

orbeckst commented Oct 9, 2018

@richardjgowers no more WIP, I suppose?

@richardjgowers richardjgowers merged commit 25b27e1 into develop Oct 9, 2018
@IAlibay IAlibay deleted the start_0.19.1 branch May 29, 2022 12:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants