Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP, TST: remove gsd & add Python 2.7 to appveyor config #2093

Closed
wants to merge 2 commits into from
Closed

WIP, TST: remove gsd & add Python 2.7 to appveyor config #2093

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6cf19ff
TST: remove gsd & add Python 2.7 to appveyor config.
tylerjereddy Oct 8, 2018
aa72457
Update .appveyor.yml
richardjgowers Oct 22, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion .appveyor.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ environment:
global:
CONDA_CHANNELS: conda-forge
CONDA_DEPENDENCIES: pip setuptools wheel cython mock six biopython networkx joblib matplotlib scipy vs2015_runtime pytest mmtf-python GridDataFormats hypothesis pytest-cov codecov
PIP_DEPENDENCIES: gsd==1.5.2 duecredit
PIP_DEPENDENCIES: duecredit
DEBUG: "False"
MINGW_64: C:\mingw-w64\x86_64-6.3.0-posix-seh-rt_v5-rev1\mingw64\bin
OPENBLAS_64: https://3f23b170c54c2533c070-1c8a9b3114517dc5fe17b7c3f8c63a43.ssl.cf2.rackcdn.com/openblas-5f998ef_gcc7_1_0_win64.zip
Expand All @@ -29,6 +29,10 @@ environment:
PYTHON_ARCH: 64
MSVC_VERSION: "Visual Studio 10 Win64"

- PYTHON_VERSION: 2.7
PYTHON_ARCH: 64
MSVC_VERSION: "Visual Studio 10 Win64"
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what motivated this change? if we want to support Python 2.7 on Windows we need to use older compilers and enforce C89 standard in our C source files I think. Maybe more trouble than it is worth though.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was just playing spot the difference between the two builds and hoping it was a typo. I didn't realise we had fundamental problems like that.


init:
- ps: Write-Host ${env:PYTHON} ${env:PYTHON_VERSION} ${env:PYTHON_ARCH}
- ps: Write-Host ${env:APPVEYOR_SCHEDULED_BUILD}
Expand Down