-
Notifications
You must be signed in to change notification settings - Fork 668
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improved docstrings in lib/_augment.pyx #2062
Improved docstrings in lib/_augment.pyx #2062
Conversation
@ayushsuhane Since you wrote the augment routines (PR #1977), could you take a quick look at the new docstrings? Just to make sure I didn't add any bogus. 😉 |
Codecov Report
@@ Coverage Diff @@
## develop #2062 +/- ##
========================================
Coverage 89.26% 89.26%
========================================
Files 159 159
Lines 18678 18678
Branches 2673 2673
========================================
Hits 16672 16672
Misses 1403 1403
Partials 603 603
Continue to review full report at Codecov.
|
Mmmh... nobody up to reading some good ol' poetry? 😄 |
@zemanj Looks good. The docs are more clear now. Thanks!! 👍 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks for the review @ayushsuhane
The develop build is now failing for Python 3.4 due to an unresolvable conda dependency. I restarted the build but the problem persists. |
Fixes (partially) #2046, this is the second of a series of related PRs, following PR #2048.
Changes made in this Pull Request:
MDAnalysis.lib.distances.augment_coordinates()
andMDAnalysis.lib.distances.undo_augment()
to better explain what the methods are actually doing... autofunction
inlib/distances.py
so that the signatures of both functions are now properly displayed in the html docs.lib.distances
a bit #2048 so thatdistance_array()
now also returns an array for single coordinate input.lib.distances
a bit #2048.Apparently, there is a problem with Windows/Linux (i.e., CRLF vs. LF) line endings resulting in an incorrect
git diff
output forlib/_augment.pyx
, which now looks as if I changed every line in the file, even though I only changed the docstrings. Withgit diff -b
the changes are displayed correctly, though. On github, just change the diff settings to ignore whitespace.PR Checklist