fix cython error on travis #1675
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kain88-de
force-pushed
the
fix-cython-error
branch
from
89fa0b8 to
d0cd0f3
Compare
This fixes a pickle error we have seen with recent versions of cython and our mocked imports. cython now introduced special reduce and setstate functions to enable cross python pickling for simple classes. It also tried to do this for some encore classes that only had a run method and would overwrite the `__call__` special method. So lets make them function right away.
kain88-de
force-pushed
the
fix-cython-error
branch
from
d0cd0f3 to
2fe4bb8
Compare
|
Could you have a look as well. The tests pass on my laptop. I assume they will also pass on travis. This currently blocks all other PR's since the functions cause failures of the builds due to a cython update. |
|
@richardjgowers could you also have a look. |
|
Hi, looks good to me. I just gave it a go on my local workstation (Python 3.5.3, Cython 0.27) and tests pass. |
|
@mtiberti it would be nice if you can give a approve seal on github. Unless someone else does this I'm not allowed to hit the |
mtiberti
approved these changes
Sep 26, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #
Changes made in this Pull Request:
https://groups.google.com/forum/#!topic/cython-users/tQlwfcpdf0k
The tests fall for python 3.5> on travis now for unrelated changes. I don't really know why this happens now but it seems related to the last cython update.
PR Checklist