Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Made python 3 support official #1524

Merged
merged 2 commits into from
Jul 19, 2017
Merged

Made python 3 support official #1524

merged 2 commits into from
Jul 19, 2017

Conversation

richardjgowers
Copy link
Member

Fixes #260

Changes made in this Pull Request:

  • py 3.6 build can no longer fail
  • added python 3.4 and 3.5 to build matrix

PR Checklist

  • Tests?
  • Docs?
  • CHANGELOG updated?
  • Issue raised/referenced?

@richardjgowers
Copy link
Member Author

I need to go through and check where we state that we don't support py3

@tylerjereddy
Copy link
Member

For the build matrix failures, I think we've been starting to see these a bit more (randomly?) now:

==================================== ERRORS ====================================
_____________________________ ERROR collecting gw1 _____________________________
Different tests were collected between gw0 and gw1. The difference is:

There's an associated discussion on the pytest github, which then broke out to an xdist issue.

Is this serious enough to warrant removing the parallel testing for now? We need reproducible CI test results and cycles are currently slow / expensive / etc. Maybe a new issue needs to be opened for the discussion.

@tylerjereddy tylerjereddy mentioned this pull request Jul 19, 2017
4 tasks
@richardjgowers
Copy link
Member Author

Ok I disabled xdist for now, build times are about 30mins maximum, which is manageable for now. Should be good to merge

@richardjgowers richardjgowers added this to the 0.17.0 milestone Jul 19, 2017
Copy link
Member

@tylerjereddy tylerjereddy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. For the separate issue of the ignored exception in the 3.4/3.5 rows of the build matrix, see #1530.

@tylerjereddy
Copy link
Member

Perhaps I'll allow another @MDAnalysis/coredevs to merge, given the impact of changing the Travis build matrix & need for agreement, etc.

Copy link
Member

@orbeckst orbeckst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@richardjgowers because this PR changes the CHANGELOG with the momentous entry "we support Py 3 now", I would also like the same PR remove any of the "Py 3 is experimental" warnings as well as updates to the docs that clearly state what we're supporting; In #1446 we got the justified complaint that our docs are not clear on what we support.

@richardjgowers
Copy link
Member Author

@orbeckst that notice is already killed

@orbeckst orbeckst dismissed their stale review July 19, 2017 19:58

Because the request changes were done elsewhere.

@kain88-de kain88-de merged commit 301c7eb into develop Jul 19, 2017
@kain88-de kain88-de deleted the issue-260-py3 branch July 19, 2017 20:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants