Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Aux cleaning #1290

Merged
merged 2 commits into from
Apr 8, 2017
Merged

Aux cleaning #1290

merged 2 commits into from
Apr 8, 2017

Conversation

jbarnoud
Copy link
Contributor

@jbarnoud jbarnoud commented Apr 8, 2017

Fixes #1289

Changes made in this Pull Request:

  • remove the windows end of line in XVG.py
  • make the two XVG aux reader use anyopen instead of the built in open
  • declare one test file that was already in the repo

Do not squash the commits! The removal of the windows end of lines make the diff unreadable otherwise.

Hopefully, this can be merged before the release. It would allow me to use one of the test files in MDAnalysis/MDAnalysis.github.io#26.

PR Checklist

  • Tests?
  • [ ] Docs? Fix a bug
  • [ ] CHANGELOG updated? Aux reader is new in 0.16.0
  • Issue raised/referenced?

@jbarnoud jbarnoud requested a review from kain88-de April 8, 2017 07:57
Copy link
Member

@richardjgowers richardjgowers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like the bz2 file was forgotten?

@jbarnoud
Copy link
Contributor Author

jbarnoud commented Apr 8, 2017

jbarnoud added a commit to MDAnalysis/MDAnalysis.github.io that referenced this pull request Apr 8, 2017
kain88-de pushed a commit to MDAnalysis/MDAnalysis.github.io that referenced this pull request Apr 8, 2017
@richardjgowers richardjgowers merged commit 68cade4 into develop Apr 8, 2017
@richardjgowers richardjgowers deleted the aux-cleaning branch April 8, 2017 09:05
richardjgowers pushed a commit to MDAnalysis/MDAnalysis.github.io that referenced this pull request Apr 10, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants