Adds filename attribute to MemoryReader & associated tests #1252
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
richardjgowers
requested changes
Mar 22, 2017
| @@ -242,10 +242,13 @@ def __init__(self, coordinate_array, order='fac', | |||
| dt: float, optional | |||
| The time difference between frames (ps). If :attr:`time` | |||
| is set, then `dt` will be ignored. | |||
| filename: string, optional | |||
| The name of the file from which this instance is created | |||
There was a problem hiding this comment.
Maybe state it will otherwise be None
|
@jbarnoud @richardjgowers Updated the docstring. |
richardjgowers
approved these changes
Mar 22, 2017
|
Cool, looks solid, thanks! |
jbarnoud
added a commit
that referenced
this pull request
Mar 22, 2017
I reviewed #1252 too fast and missed a mixup in the filename passed to the memory reader. The topology filename was passed instead of the trajectory one. This commit fixes the confusion.
This was referenced Mar 22, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1027
Changes made in this Pull Request:
filenameattribute toMemoryReaderPR Checklist