Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

make kwargs read only #1068

Merged
merged 1 commit into from
Nov 8, 2016
Merged

make kwargs read only #1068

merged 1 commit into from
Nov 8, 2016

Conversation

kain88-de
Copy link
Member

Fixes #292

Changes made in this Pull Request:

  • kwargs are readonly like in the old system

PR Checklist

  • [x] Tests?
  • Docs?
  • [x] CHANGELOG updated?
  • Issue raised/referenced?

richardjgowers
richardjgowers approved these changes Nov 8, 2016
View reviewed changes
Copy link
Member

@richardjgowers richardjgowers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks sane enough

@richardjgowers
Copy link
Member

Is this still needed @kain88-de ? Or was it MDS's fault?

@kain88-de
Copy link
Member Author

MDS accessed a hidden kwargs variable. But I still like the idea to have kwargs read-only.

@richardjgowers richardjgowers merged commit 992aaa4 into MDAnalysis:develop Nov 8, 2016
@kain88-de kain88-de deleted the fix-kwargs-universe branch November 18, 2016 07:31
abiedermann pushed a commit to abiedermann/mdanalysis that referenced this pull request Jan 5, 2017
@kain88-de @richardjgowers
make kwargs read only (MDAnalysis#1068)
2dfa20a
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@richardjgowers richardjgowers richardjgowers approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kain88-de @richardjgowers