Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use physical units in AtomGroup objects. #596

Open
kain88-de opened this issue Dec 16, 2015 · 5 comments
Open

Use physical units in AtomGroup objects. #596

kain88-de opened this issue Dec 16, 2015 · 5 comments

Comments

@kain88-de
Copy link
Member

There's been a comment on the mailing list that it would be nice to have units attached to the Atomgroup objects.

I think that is a great idea. We can have a look into one of the many packages that provide unit aware numpy arrays.

@jbarnoud
Copy link
Contributor

The easiest way would be to copy the unit dict from the reader somewhere accessible from the universe. Yet, this dict could contain unit objects rather than strings.

@orbeckst
Copy link
Member

We could then also clean up the hacks in MDAnalysis.units and replace them by more general unit conversions.

@richardjgowers
Copy link
Member

We've got a nice system of Attribute or Timestep holding all data now, and
AtomGroups requesting data. It would be cool to make the holders do the
conversion, rather than the requestors. So I'd set the mass Attribute to
have unit=kg and any further use of it would give those units.

On Wed, 16 Dec 2015 02:17 Oliver Beckstein [email protected] wrote:

We could then also clean up the hacks in MDAnalysis.units and replace
them by more general unit conversions.


Reply to this email directly or view it on GitHub
#596 (comment)
.

@richardjgowers
Copy link
Member

@tylerjereddy
Copy link
Member

Also worth noting that facilitating third-party dtype specification is on the NumPy roadmap so if there is specific feedback re: things that MDA needs to make this easier I can relay that information. Be able to write the dtype in pure Python is on the roadmap, albeit somewhat ambitious for more useful dtypes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants