-
Notifications
You must be signed in to change notification settings - Fork 663
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MDAnalysis.analysis.rms.rmsd docs do not show versionchanged entries #4014
Comments
you are saying to add these things ?
|
They are currently present in the docstring, we just need to amend things so that they get rendered by sphinx. |
Hey, I am just a beginner and this will be my first issue. Can you @IAlibay assign me this issue and help me understand what do I have to do and how? |
@MeetB7 - we unfortunately don't assign issues to folks unless they are part of a wider set of project items. In this case whomever first opens a pull request with the necessary changes would get their code ammendments reviewed.
It's a bit difficult for me to capture what additional information you might need here. Could I maybe turn this around and ask what of the above given information are you unsure about / needs clarification? I would also urge you to have a look at the contributing portion of the userguide if you haven't done so yet: https://userguide.mdanalysis.org/stable/contributing_code.html |
@IAlibay if they already exist in docstring, what do you mean by 'amend things' so they get rendered |
So here what we mean is that in the ideal world sphinx should have picked up that these versionchanged entries are present and should be showing them in the rendered docs (see https://docs.mdanalysis.org/dev/documentation_pages/analysis/rms.html#MDAnalysis.analysis.rms.rmsd). However it doesn't, which mean that we need to fix the docstring in such a way that sphinx can pick them up and render them. Usually this is a small change in the amount of empty lines, but the correct answer will require delving into the sphinx documentation and doing some trial and error locally to see what changes are necessary for it to work. |
HI, I Want to work on this issue please assign this to me |
* fix #4014 * fix MDAnalysis.analysis.rms.rmsd docs version error * Updated AUTHORS * Updated CHANGELOG
Expected behavior
Docstring shows any versionchanged entries that have been added to the docstring.
Actual behavior
Despite having
versionchanged
entries, the docs for https://docs.mdanalysis.org/dev/documentation_pages/analysis/rms.html#MDAnalysis.analysis.rms.rmsd don't seem to be showing them.It's possibly down to the number of empty lines there should be between the doctest block and the versionchange entries, but it will need further investigation.
Current version of MDAnalysis
Happening in the current dev branch of MDAnalysis.
The text was updated successfully, but these errors were encountered: