-
Notifications
You must be signed in to change notification settings - Fork 658
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ENCORE uses an non existing method #3539
Comments
4 tasks
@mtiberti @wouterboomsma could you please let us know what you had intended with this method? |
Hi, sorry for the delay and thanks for noticing this - I did some digging and it is indeed a leftover of when we had our own |
PR would be good. The main thing is a test that checks the code path.
… Am 3/28/22 um 00:18 schrieb Matteo Tiberti ***@***.***>:
Hi, sorry for the delay and thanks for noticing this - I did some digging and it is indeed a leftover of when we had our own Ensemble class. It should be fine to replace it with reference.select_atoms(select). Should I open a PR?
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you commented.
|
4 tasks
Thank you Matteo. If you find the time, it would be good if you could
indeed.
…On 3/28/22 09:18, Matteo Tiberti wrote:
Hi, sorry for the delay and thanks for noticing this - I did some
digging and it is indeed a leftover of when we had our own |Ensemble|
class. It should be fine to replace it with
|reference.select_atoms(select)|. Should I open a PR?
—
Reply to this email directly, view it on GitHub
<#3539 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAKRNOQQMGPJZCHHS5GFGULVCFMMVANCNFSM5OURX46Q>.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
ENCORE uses an non existing method
AtomGroup.get_selection_atom_string
: #3479 (comment)Ping @mtiberti and @wouterboomsma
The text was updated successfully, but these errors were encountered: