-
Notifications
You must be signed in to change notification settings - Fork 657
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Failed doc examples in align.py #3365
Comments
Should we tag this with |
Sure :) There are actually two issues here, and people should feel welcome to only fix one in a PR if they want. The important errors are:
Here, the fix is fairly simple -- change the expected number.
Here, the problem is less simple -- a whole universe needs to be defined to substitute The automated CI won't catch the problem, so it would be great if anyone who opened a PR pasted the code into a notebook or iPython to demonstrate it works. |
Hello @lilyminium, |
I would like to solve this issue. can you please provide some more details and how to approach this. |
Hi, I would like to work on this Issue. it would be great could you please assign this issue to me |
I want to solve this issue please assign me this issue |
Hi @jhunjhunwala1234, usually issues are not assigned to people in MDAnalysis. If you want to work on an issue, just work on it and open a pull request with your fix when you think it's ready. Other developers will then review your PR, on a first come first served basis. Please note that there is already an open PR addressing this issue (see PR #4023). |
hi i want work on this issue please assing me this issue |
I want to solve this issue please assign me this issue because of my study area B.Tech CSE (Data Science) |
@pradeeprao31, as explained above we don’t assign issues. If you want to work on an issue, just work on it and open a pull request with your fix when you think it's ready. Just make sure there is not an active PR against the issue you want to work on, since earlier PRs will be reviewed first. |
Dear mentors, I just opened a PR #4182. Please review it. |
Dear mentors,
Thank you for notifying us about PR #4182. We will review it promptly and
provide our feedback.
Best regards,
[pradeep kumar]
<https://gpt.space/gmail?source=watermark>r
…On Fri, Jun 30, 2023 12:16 PM, ***@***.*** wrote:
Dear mentors, I just opened a PR #4182
<#4182>. Please review it.
—
Reply to this email directly, view it on GitHub
<#3365 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/A2GE4D3IJNXOMA6A6AR5GP3XNZC33ANCNFSM5AT2RYLQ>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
* fix #3365 * fixed all doc tests in analysis.align * Update AUTHORS * Update CHANGELOG
Expected behavior
Sub-issue of #760
Doc examples work.
Actual behavior
This is after changing a
>>>
in the rotation matrix example to...
Code to reproduce the behavior
Current version of MDAnalysis
python -c "import MDAnalysis as mda; print(mda.__version__)"
) 8f9f402python -V
)? 3.7.3The text was updated successfully, but these errors were encountered: