Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow setting user box dimensions to a multidimensional array. #3217

Closed
hmacdope opened this issue Apr 6, 2021 · 5 comments
Closed

Allow setting user box dimensions to a multidimensional array. #3217

hmacdope opened this issue Apr 6, 2021 · 5 comments
Labels

Comments

@hmacdope
Copy link
Member

hmacdope commented Apr 6, 2021

Is your feature request related to a problem?

You should be able to set the box size manually over your whole trajectory. Related to #2691, however the fix in #3175 (NOTE: currently pending merge) only sets the box dimensions to a constant [a, b, c,alpha, beta, gamma].

Describe the solution you'd like

This can be done easily with a multidimensional array of shape timesteps, [a, b, c,alpha, beta, gamma] and something like the below:

def set_traj_dimensions(input_dims, u):
    for i, ts in  enumerate(u.trajectory):
		ts.dimensions = input_dims[i,:] 

Describe alternatives you've considered

Additional context

You cannot work on this issue until #3175 is merged.

@hmacdope hmacdope added GSOC Starter Component-Transformations On-the-fly transformations labels Apr 6, 2021
@lilyminium
Copy link
Member

lilyminium commented Apr 6, 2021 via email

@yizhuang1
Copy link

Hi, is this thread still available for GSoC? I'd like to make a contribution. Thanks!

@hmacdope
Copy link
Member Author

@yizhuang1 yes it! Go ahead and make a PR. :)

@nancyalaswad90
Copy link

Hi everyone 😊

Please advise me on how we distinguish between the active or close issues?

@orbeckst
Copy link
Member

orbeckst commented Jan 4, 2024

As @ljwoods2 correctly pointed out in #4400 , the current implementation

class set_dimensions(TransformationBase):
already allows setting the box dimension from an array for all frames of the trajectory. This behavior was added in f50a097 as part of PR #4258 .

@orbeckst orbeckst closed this as completed Jan 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

5 participants