Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add CI runner with older versions of chemfiles #3216

Closed
Luthaf opened this issue Apr 5, 2021 · 2 comments · Fixed by #3490 or #3499
Closed

Add CI runner with older versions of chemfiles #3216

Luthaf opened this issue Apr 5, 2021 · 2 comments · Fixed by #3490 or #3499
Labels
Continuous Integration testing

Comments

@Luthaf
Copy link
Contributor

Luthaf commented Apr 5, 2021

Can you open an issue about covering this so we don't forget? I was working on a weekly cron CI job somewhere else, I can probably just add a workflow that installs older versions of chemfiles.

Originally posted by @IAlibay in #3126 (comment)
@Luthaf
Copy link
Contributor Author

Luthaf commented Apr 5, 2021

For the record, I don't plan on supporting more than one release of chemfiles until I reach version 1.0. I can support the master/dev version and the latest release (version 0.10.x right now), but I will not have the time to add patches or make new release in the 0.9 series.

I can see the advantage for users to ensure that one more version of the API is supported in MDAnalysis, but if someone runs into an issue with 0.9.3, I would rather point them to version 0.10 instead.

@IAlibay IAlibay mentioned this issue Dec 31, 2021
Merged
1 task
@IAlibay IAlibay mentioned this issue Jan 8, 2022
Merged
4 tasks
IAlibay pushed a commit that referenced this issue Jan 8, 2022
@Luthaf
Chemfiles version support update & switch from disutils.version (#3499)
d1fd748 
Fixes #3492 #3498 #3216
* Use packaging.version.Version instead of deprecated distutils.version.LooseVersion
* Drop support for chemfiles 0.9
@IAlibay
Copy link
Member

IAlibay commented Jan 8, 2022

Setting as fixed with #3499 since it's no longer required. We may re-visit once several versions of Chemfiles need supporting again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Continuous Integration testing
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Cleanup of CI actions & cron job MDAnalysis/mdanalysis
Chemfiles updates Luthaf/mdanalysis
2 participants
@Luthaf @IAlibay