Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

option to turn off the mass match in alignto() #2285

Closed
xiki-tempula opened this issue Jul 5, 2019 · 3 comments · Fixed by #2380
Closed

option to turn off the mass match in alignto() #2285

xiki-tempula opened this issue Jul 5, 2019 · 3 comments · Fixed by #2380

Comments

@xiki-tempula
Copy link
Contributor

xiki-tempula commented Jul 5, 2019

Is your feature request related to a problem? Please describe.
When one might want to convert the coarse-grain simulation to atomistic simulation, one will usually align the crystallographic protein to the coarse-grain protein.

Describe the solution you'd like
Ideally, this should be done using

from MDAnalysis.analysis.align import alignto
alignto(AT.atoms, CG.atoms, select=('name CA', 'name BB'))

However, since the mass of the CG backbone bead has a different mass from the CA atoms, the error MDAnalysis.exceptions.SelectionError: Inconsistent selections, masses differ by more than 0.1; mis-matching atoms are shown above.
is raised and there isn't a way of turning this off.

@orbeckst
Copy link
Member

A dirty workaround should be to set tol_mass=1000 in alignto().

@orbeckst
Copy link
Member

@xiki-tempula did this do anything for you?

@xiki-tempula
Copy link
Contributor Author

@orbeckst Thank you for the information. I kind of just did my own fork and move the raise exception part to the actions under strict keyword, so if strict=False then the exception won't get raised. However, I do notice that strict=False is set to False by Default so my method of disabling the mass checking when strict=False might not be good for naive users. Thus, I raise an issue and hope to see what are people's opinion on this.

@orbeckst orbeckst changed the title Is it possible to turn off the mass match in alignto()? option to turn off the mass match in alignto() Jul 18, 2019
orbeckst pushed a commit that referenced this issue Nov 7, 2019
* Fixes #2285
* added match_atoms keyword to analysis.align
* added issue
* added test
* removed redundant test
* logged error
* split tests
* moved match_atoms to 0.21.0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants