Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(experimental) conda package for Windows #2116

Closed
orbeckst opened this issue Oct 21, 2018 · 12 comments
Closed

(experimental) conda package for Windows #2116

orbeckst opened this issue Oct 21, 2018 · 12 comments

Comments

@orbeckst
Copy link
Member

Even though we do not fully support Windows (yet) we would like to have (experimental) conda packages for Windows.

  • Code that is not working yet should be disabled under Windows (example: GSD Reader).
  • Have MDA issue an initial warning that Windows support is experimental.

(This came out of a discussion regarding the Workshop. We would like to test if the basic examples work under Windows.)

@orbeckst
Copy link
Member Author

@kain88-de @tylerjereddy @richardjgowers do you know how to build Windows packages on conda-forge?

@tylerjereddy
Copy link
Member

I'll make a note about this.. I think I'm slotted in as release manager for the next SciPy release so should probably brush up anyway.

@richardjgowers
Copy link
Member

The optimist in me hopes we can just delete the skip windows line here:

https://github.com/conda-forge/mdanalysis-feedstock/blob/master/recipe/meta.yaml#L16

Then maybe add any fixes that @tylerjereddy has had to use on our windows CI?

@kain88-de
Copy link
Member

kain88-de commented Oct 22, 2018 via email

@richardjgowers
Copy link
Member

So hopefully the build passes without too much drama. I'm thinking I should go through and "deactivate" the modules that don't work for Windows (like we recently did for GSD). I think this will be most of the ascii based multi frame readers(!).

But then everything accessible within the module should work 100%

@kain88-de
Copy link
Member

oh yeah but I don't know how to have optional requirements in a conda package. We have to make those truly optional with correct error messages in MDAnalysis. So I assume now the build will fail until the dependencies are removed.

@richardjgowers
Copy link
Member

@kain88-de we've got the code in place to handle optional GSD, so it's just the recipe, I've tried something...

@richardjgowers
Copy link
Member

This is done, https://anaconda.org/conda-forge/mdanalysis

I don't consider this experimental either, everything is passing identically to linux

@orbeckst
Copy link
Member Author

orbeckst commented Nov 6, 2018

🍺

@orbeckst
Copy link
Member Author

orbeckst commented Nov 6, 2018

Do we only support Python 3 on Windows?

https://anaconda.org/conda-forge/mdanalysis/files

@richardjgowers
Copy link
Member

@orbeckst yep: #2093 (comment)

@orbeckst
Copy link
Member Author

orbeckst commented Nov 9, 2018

Should mention this somewhere... at least in upcoming blog post MDAnalysis/MDAnalysis.github.io#94

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants