Skip to content

Commit

Permalink
Added link to jupyter notebook [skip ci]
Browse files Browse the repository at this point in the history
  • Loading branch information
jdetle committed Jul 6, 2016
1 parent c5d1958 commit d7cd454
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion package/MDAnalysis/analysis/diffusionmap.py
Original file line number Diff line number Diff line change
Expand Up @@ -94,7 +94,7 @@
for the user. The `diffusion distance` between frames i and j is best
approximated by the euclidean distance between rows i and j of
self.diffusion_space. A Jupyter notebook providing an analysis of protein
opening and closing is provided [here](#TODO url to notebook)
opening and closing is provided [here.](https://github.com/jdetle/dimension_reduction/blob/master/diffusionMaps/Diffusion_Map_Analysis_of_ADK.ipynb)

This comment has been minimized.

Copy link
@orbeckst

orbeckst Jul 6, 2016

Member

Generally, links on the word "here" are considered poor semantics. Much better to put the link on an actual noun, e.g.

"See also this Jupyter notebook that uses diffusion maps to analyse the opening and closing motion of AdK."

Eventually, such notebooks should be collected somewhere under the MDAnalysis umbrella — see also MDAnalysis/MDAnalysis.github.io#4. If we use a separate notebooks repo for them then we can make them easily available as http://mdanalysis.org/notebooks.

This comment has been minimized.

Copy link
@jdetle

jdetle Jul 6, 2016

Author Contributor

Thanks for the heads up. I will change this link to the notebook for now, and then towards the end of the Summer hopefully we can have a notebooks repo up and running.

This comment has been minimized.

Copy link
@jdetle

jdetle Jul 6, 2016

Author Contributor

Also, this is probably something I should work on in my blog! Thanks for the tip.

Classes
-------
Expand Down

0 comments on commit d7cd454

Please sign in to comment.