Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix get_cmap deprecation #39

Merged
merged 1 commit into from
Jan 3, 2024
Merged

fix get_cmap deprecation #39

merged 1 commit into from
Jan 3, 2024

Conversation

IAlibay
Copy link
Member

@IAlibay IAlibay commented Nov 3, 2023

2023-11-03T03:16:21.0968186Z /home/runner/work/mdanalysis/mdanalysis/package/MDAnalysis/analysis/hole2/hole.py:874: MatplotlibDeprecationWarning: The get_cmap function was deprecated in Matplotlib 3.7 and will be removed two minor releases later. Use matplotlib.colormaps[name] or matplotlib.colormaps.get_cmap(obj) instead.

Copy link

codecov bot commented Nov 3, 2023

Codecov Report

Merging #39 (e8f3ca9) into main (d65dc01) will increase coverage by 0.17%.
The diff coverage is 100.00%.

Additional details and impacted files

@IAlibay IAlibay requested a review from lilyminium January 3, 2024 06:49
@IAlibay
Copy link
Member Author

IAlibay commented Jan 3, 2024

@lilyminium it would be good to get this merged before we deploy this kit / do the next release.

Copy link
Member

@lilyminium lilyminium left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @IAlibay!

@IAlibay IAlibay merged commit 9271592 into main Jan 3, 2024
17 checks passed
@IAlibay IAlibay deleted the fix-cmap branch January 6, 2024 07:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants