Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Port Tyler's fix from the core library #38

Merged
merged 1 commit into from
Oct 31, 2023
Merged

Port Tyler's fix from the core library #38

merged 1 commit into from
Oct 31, 2023

Conversation

IAlibay
Copy link
Member

@IAlibay IAlibay commented Oct 28, 2023

@codecov
Copy link

codecov bot commented Oct 28, 2023 •
edited
Loading

Codecov Report

Merging #38 (c6dbe86) into main (7fa75f5) will not change coverage.
The diff coverage is 100.00%.

Additional details and impacted files

@IAlibay IAlibay mentioned this pull request Oct 29, 2023
Closed
tylerjereddy
tylerjereddy approved these changes Oct 31, 2023
View reviewed changes
Copy link
Member

@tylerjereddy tylerjereddy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CI is happy, and it is a simple port of a one-line patch from the main/core project that provides 3.12 compatibility.

@tylerjereddy tylerjereddy merged commit d65dc01 into main Oct 31, 2023
17 checks passed
@tylerjereddy tylerjereddy deleted the py312-fix branch October 31, 2023 16:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tylerjereddy tylerjereddy tylerjereddy approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@IAlibay @tylerjereddy