Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add macOS to CI #35

Merged
merged 4 commits into from
Oct 19, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/gh-ci.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,7 @@ jobs:
fail-fast: false
matrix:
# os: [macOS-latest, ubuntu-latest, windows-latest]
os: [ubuntu-latest]
os: [ubuntu-latest, macOS-latest]
python-version: ["3.9", "3.10", "3.11"]
mdanalysis-version: ["latest", "develop"]

Expand Down
1 change: 1 addition & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,7 @@ The rules for this file:
- ianmkenney

### Added
- mdahole2 confirmed to work on macOS and is now included in CI (PR #35)
<!-- New added features -->

### Fixed
Expand Down
4 changes: 3 additions & 1 deletion README.md
Original file line number Diff line number Diff line change
Expand Up @@ -13,13 +13,15 @@ mdahole2 is bound by a [Code of Conduct](https://github.com/MDAnalysis/hole2-mda

### Installation

To build mdahole2 from source,
To build `mdahole2` from source,
we highly recommend using virtual environments.
If possible, we strongly recommend that you use
[Anaconda](https://docs.conda.io/en/latest/) as your package manager.
Below we provide instructions both for `conda` and
for `pip`.

Note that `mdahole2` is only supported on Linux and macOS.

#### With conda

Ensure that you have [conda](https://docs.conda.io/projects/conda/en/latest/user-guide/install/index.html) installed.
Expand Down
9 changes: 5 additions & 4 deletions docs/source/getting_started.rst
Original file line number Diff line number Diff line change
@@ -1,7 +1,8 @@
Getting Started
===============

This page details how to get started with `mdahole2`.
This page details how to get started with ``mdahole2``.
Note that ``mdahole2`` is only supported on Linux or macOS.

Documentation
~~~~~~~~~~~~~
Expand All @@ -13,7 +14,7 @@ Documentation is hosted on `GitHub Pages`_.
Download source code
~~~~~~~~~~~~~~~~~~~~

The `mdahole2` source code is hosted on GitHub_ and can be downloaded with
The ``mdahole2`` source code is hosted on GitHub_ and can be downloaded with

.. code:: bash

Expand All @@ -30,8 +31,8 @@ with an SSH key, or with
Build and installation
~~~~~~~~~~~~~~~~~~~~~~

`mdahole2` is currently only installable from source (although hosting on conda-forge is planned).
As such `conda-build` is required. To download this utility, invoke:
``mdahole2`` is currently only installable from source (although hosting on conda-forge is planned).
As such ``conda-build`` is required. To download this utility, invoke:

.. code:: bash

Expand Down
2 changes: 1 addition & 1 deletion setup.py
Original file line number Diff line number Diff line change
Expand Up @@ -53,7 +53,7 @@
"mdanalysis>=2.0.0",
],
# Additional entries you may want simply uncomment the lines you want and fill in the data
# url='mdahole2.readthedocs.io/en/latest/', # Website
url='https://www.mdanalysis.org/hole2-mdakit',
# platforms=['Linux',
# 'Mac OS-X',
# 'Unix',
Expand Down
Loading