-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes to the docs theme #23
Conversation
- Added msmb_theme dependency in workflow - Added sphinx_rtd_theme to requirements.yaml - Added new custom.css and MDA logos - Updated conf.py
Can you link to a PR build on RTD so that I can check visually? We should be doing such a build for each PR but I cannot set it under checks. |
@orbeckst we're using github pages, I'm not quite sure how to show the outputs of those builds on PRs, I might have to revisit this later then |
Yes, but for other projects (see MDA, for example, possibly also gridDataFormats) we are also building a RTD to preview docs. I had thought we did this here as well. It probably just needs enabling RTD and enabling a hook in RTD… but I don’t remember details. Am 7/14/23 um 12:00 schrieb Ian Kenney ***@***.***>:
@orbeckst we're using github pages
—Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you were mentioned.Message ID: ***@***.***>
|
@orbeckst Alright, docs are building, see https://mdakithole2--23.org.readthedocs.build/en/23/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good & thanks for adding the RTD PR check.
Fixes #13