Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MDA-style docs #70

Merged
merged 11 commits into from
Nov 24, 2021
Merged

MDA-style docs #70

merged 11 commits into from
Nov 24, 2021

Conversation

orbeckst
Copy link
Member

@orbeckst orbeckst commented Nov 19, 2021

- make README the landing page of the docs
- hide explicit TOC (available in sidebar in the MDA style)
- remove links to module index etc as not needed
@orbeckst
Copy link
Member Author

I used the standard MDA styles to give you a starting point . I also created a simple logo as a placeholder.

@orbeckst
Copy link
Member Author

Needs

  • sphinx_rtd_theme
  • sphinx_sitemap

@codecov
Copy link

codecov bot commented Nov 19, 2021

Codecov Report

Merging #70 (a6f42f5) into main (065ed9d) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main      #70   +/-   ##
=======================================
  Coverage   81.31%   81.31%           
=======================================
  Files           8        8           
  Lines         519      519           
  Branches       91       91           
=======================================
  Hits          422      422           
  Misses         77       77           
  Partials       20       20           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 065ed9d...a6f42f5. Read the comment docs.

@orbeckst
Copy link
Member Author

Docs build (see https://mdacli--70.org.readthedocs.build/en/70/) but other tests fail due to some issue with bump_version. Please have a look. Thanks.

Copy link
Member

@joaomcteixeira joaomcteixeira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great addition. thanks! 😉

I made some changes to pass CI, but not completed yet. Need to clean some details in the documentation.

tox -e docs tells what is missing.

@orbeckst
Copy link
Member Author

@joaomcteixeira I am not sure what I could do to fix the remaining issuse. Can I leave this to you?

Comment on lines +8 to +9
<script data-goatcounter="https://mdanalysis.goatcounter.com/count"
async src="//gc.zgo.at/count.js"></script>
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note that this part is necessary for analytics.

The number of page accesses is actually an important number for us to demonstrate impact so we do want to keep track of which pages are seen. This is fully anonymous, though.

]

# for sitemap with https://github.com/jdillard/sphinx-sitemap
site_url = "https://www.mdanalysis.org/mdacli/"
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

in preparation for #71

@PicoCentauri
Copy link
Collaborator

Thanks @orbeckst!

I fixed the CI (adding a required CHANGELOG entry) and updated the AUTHORS. LGTM. @joaomcteixeira if you want to update the docs do it and merge when you think.

Just to know. For adding it to https://www.mdanalysis.org/mdacli we should update our github action for pushing it right?

@orbeckst
Copy link
Member Author

Just to know. For adding it to https://www.mdanalysis.org/mdacli we should update our github action for pushing it right?

Yes. You can definitely keep your RTD as well but when we refer to the docs we refer to the ones hosted under mdanalysis.org.

Once that's up, we add your mdacli/sitemap.xml to https://www.mdanalysis.org/sitemapindex.xml so that (1) search engines can find everything and (2) the search on the website itself will eventually find the docs (although there are currently some issues with the search MDAnalysis/MDAnalysis.github.io#202).

@PicoCentauri
Copy link
Collaborator

Okay! Sounds like a good plan. I suggest we create another PR for displaying the docs at mdanalysis.org including a sitemap and merge this one asap.

@orbeckst
Copy link
Member Author

I switched the logo to the same one that you used in PR MDAnalysis/MDAnalysis.github.io#207 ; from my end I think everything is done here. Now up to @PicoCentauri and @joaomcteixeira .

@PicoCentauri PicoCentauri merged commit b88ddc8 into main Nov 24, 2021
joaomcteixeira added a commit that referenced this pull request Nov 24, 2021
MDA-style docs (#70)

* Added mdacli logo
* change style to MDAnalysis documentation
* improve landing page
* update dependencies for docs
* removed stupid macOS .DS_Store file
* Update AUTHORS and CHANGELOG

Co-authored-by: joaomcteixeira <[email protected]>
Co-authored-by: Philip Loche <[email protected]>
@PicoCentauri PicoCentauri deleted the mdastyle-docs branch November 24, 2021 19:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

use MDA style for docs
3 participants