Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix missing closing parenthesis in deploy workflow #13

Merged
merged 1 commit into from
Sep 19, 2024
Merged

fix missing closing parenthesis in deploy workflow #13

merged 1 commit into from
Sep 19, 2024

Conversation

orbeckst
Copy link
Member

No description provided.

@orbeckst orbeckst requested a review from IAlibay September 18, 2024 23:54
@orbeckst
Copy link
Member Author

I am pretty sure that this needs to be fixed because I copied it (thank you!) and got the error

Invalid workflow file: .github/workflows/deploy.yaml#L18
The workflow is not valid. .github/workflows/deploy.yaml (Line: 18, Col: 9): Unexpected end of expression: ')'. Located at position 114 within expression: github.repository == 'Becksteinlab/numkit' &&
(github.event_name == 'push' && startsWith(github.ref, 'refs/tags/')

IAlibay
IAlibay approved these changes Sep 19, 2024
View reviewed changes
Copy link
Member

@IAlibay IAlibay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, I'm not sure exactly how this went through several release cycles without issues..

@IAlibay IAlibay merged commit 81e5427 into main Sep 19, 2024
@IAlibay IAlibay deleted the fix-deploy-closing-parenthesis branch September 19, 2024 00:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@IAlibay IAlibay IAlibay approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@orbeckst @IAlibay