Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

benchmark Python 3.x #9

Closed
9 tasks done
orbeckst opened this issue Jul 17, 2018 · 6 comments
Closed
9 tasks done

benchmark Python 3.x #9

orbeckst opened this issue Jul 17, 2018 · 6 comments
Assignees

Comments

@orbeckst
Copy link
Member

orbeckst commented Jul 17, 2018

At the moment we only run Python 2.7 (benchmarking from release 0.11.0 onwards).

However, since we are fully supporting Python 3 since 0.17.0, we should add benchmarks starting from release 0.17.0 that run under Python 3.6. We still need to run a cython matrix #7 but the results might be interesting because I don't know if there's any performance difference between Python 2 and 3.

Things to do

  • make sure that we only run 3.6 benchmarks since 0.17.0: in benchmarking/benchmarks/scripts/cron.sh
     timeout 20h asv run -e -j 4 --config ${ASV_CONFIG} "release-0.17.0..HEAD --merges" --skip-existing || true
  • change matrix to 3.6 in ASV_CONFIG="${ASV_RUN_DIR}/asv_c3potato.conf.json"
    "pythons": ["3.6"]
  • disable cron job until history is built up
  • manually run to build a history from the earlier merge commits
  • test that new results appear in https://www.mdanalysis.org/benchmarks/
  • test cron job
  • update wiki docs (ongoing)
@orbeckst orbeckst self-assigned this Jul 17, 2018
@orbeckst
Copy link
Member Author

I can just add Python 3.6 to the matrix but that does not give me a convenient way to restrict it to specific commits.

Perhaps I'll just let it run and let ASV run as many tests as it can get to run... (however, the initial backlog will probably take almost a week to run).

@orbeckst
Copy link
Member Author

The 3.6 history is currently being run – will take about 5 days.

@orbeckst
Copy link
Member Author

orbeckst commented Jun 12, 2020

(Continue from MDAnalysis/mdanalysis#2747 (comment))

EDIT: moved to main issue text

orbeckst added a commit that referenced this issue Jun 13, 2020
- see #9
- data are incomplete (at about 18%)
orbeckst added a commit that referenced this issue Jun 13, 2020
@orbeckst
Copy link
Member Author

Re-open until the cron job is running again.

@orbeckst orbeckst reopened this Jun 13, 2020
@orbeckst
Copy link
Member Author

I pushed partial results with Python 3.6 to https://www.mdanalysis.org/benchmarks/. Sometimes Python 3.6 is faster, sometimes it's slower. Once we have more data, we should look into which Python 3.6 constructs are problematic. For example, all PBC-related tests are slower in 3.6. For others the picture is mixed.

orbeckst added a commit that referenced this issue Jun 16, 2020
- see #9
- data are incomplete (at about 58%)
@orbeckst
Copy link
Member Author

The initial backlog was ran and we now have Py 3.6 benchmarks since ~0.17.0. The cron job should be working.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant