-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Document darker usage #274
Conversation
I think there's a misconception here, we never ask folks to pass the darker requirements, only the flake8 ones. The only reason we have the darker bot is because there are no other tools out there that run a minimal pep8 / flake8 check on diffs. (edit: what I mean here is that I do appreciate the optional label, but we need to make it clear that it's only flake/pep8 on diffs that matter) |
right, I thought this line was supposed to show them just that:
Or does flake8 enforce other checks beyond PEP8? If so, how do users know the difference between a PEP8 violation like this one: and any other formatting requirement like breaking lists into 1-element-per-line? |
I'm not on my desktop at the moment, but if I remember correctly, that line will show both My point being that if they want to |
Ok, now I get it. I think this should do. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks this looks reasonable to me from a very quick review, but I'll let another coredev do the proper review. I'm throwing this at @fiona-naughton but if someone else has time please chime in.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
just one little spelling fix, but otherwise lgtm!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great - thanks @pgbarletta !
Fixes #247
This is another section of the documentation where this issue is discussed, though it does recommend using
black
as a formatter, which kind of goes against the philosophy behind the usage of darker, since black doesn't allow partial reformatting.Let me know if you want me to harmonize the 2 sections.