Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add instructions for using Docker for local jekyll build #334

Merged
merged 2 commits into from
Oct 10, 2023

Conversation

orbeckst
Copy link
Member

Update to the README: From hackathon: How to build the docs locally using a docker container because somehow all the ruby packages live in the 5th circle of dependency hell.

Copy link
Member

@IAlibay IAlibay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not going to block because lgtm otherwise, but maybe it should be best practices to just do this.

README.md Outdated Show resolved Hide resolved
- make docker-based Jekyll first entry in how to run locally
- restructured local run a bit
Copy link
Member

@IAlibay IAlibay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@orbeckst orbeckst merged commit f00e6c5 into master Oct 10, 2023
@orbeckst orbeckst deleted the install-jekyll-docker branch October 10, 2023 19:04
@hmacdope
Copy link
Member

Thank god for this, I haven't been able to get a working build after several attempts.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants