Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MAINT] Add gh actions CI #90

Merged
merged 10 commits into from
Sep 14, 2021
Merged

[MAINT] Add gh actions CI #90

merged 10 commits into from
Sep 14, 2021

Conversation

IAlibay
Copy link
Member

@IAlibay IAlibay commented Sep 14, 2021

Fixes #86

Changes:

  • Added GH actions CI
  • Replaced appveyor with gh actions windows runner (it's slightly different [we no longer test a pip only installation world], but this might just be cleaner?)
  • Added action for docs deployment
  • Added new badges, including NF

@IAlibay
Copy link
Member Author

IAlibay commented Sep 14, 2021

appveyor ci setup is just broken, will try migrating to gh actions.

@IAlibay IAlibay requested a review from orbeckst September 14, 2021 23:09
@IAlibay
Copy link
Member Author

IAlibay commented Sep 14, 2021

If you agree to just removing appveyor @orbeckst we can also close #85 - we'll need to remove the hook for it in settings too.

I guess I can't test that docs actually works until this gets merged. We'll have to fix it live if I made a typo somewhere.

Copy link
Member

@orbeckst orbeckst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good — if we have to fix it live then we'll just do that, no big deal here

thanks a lot!

@orbeckst
Copy link
Member

This repo does not have any required checks it seems... probably something to update when the new CI is working.

@orbeckst orbeckst merged commit 160ddca into master Sep 14, 2021
@orbeckst orbeckst linked an issue Sep 14, 2021 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

MAINT: Switch from Travis to Github actions for CI MNT: Stop using ci-helpers in appveyor.yml
2 participants