Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add more digits to the delta of openDX #89

Merged
merged 11 commits into from
Sep 17, 2021

Conversation

xiki-tempula
Copy link
Contributor

Fix #88

@pep8speaks
Copy link

pep8speaks commented Sep 10, 2021

Hello @xiki-tempula! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻

Comment last updated at 2021-09-15 22:17:02 UTC

Copy link
Member

@IAlibay IAlibay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you update against master CI should now be green (hopefully?)

I'll let @orbeckst do the final review here (since I'm technically new to this repo).

I think you need to add yourself to AUTHORS?

gridData/OpenDX.py Show resolved Hide resolved
Copy link
Member

@orbeckst orbeckst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR, @xiki-tempula ; please add

  • CHANGELOG
  • AUTHORS
  • small test that checks that the guaranteed number of digits is saved (and read) — maybe just use your example
  • add entry to docs for OpenDX stating how we are saving (for instance, for PyMOL we have an entry on precision)

@codecov
Copy link

codecov bot commented Sep 15, 2021

Codecov Report

Merging #89 (2e1402c) into master (729d04c) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #89   +/-   ##
=======================================
  Coverage   87.59%   87.59%           
=======================================
  Files           5        5           
  Lines         814      814           
  Branches      118      118           
=======================================
  Hits          713      713           
  Misses         60       60           
  Partials       41       41           
Impacted Files Coverage Δ
gridData/OpenDX.py 82.88% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 729d04c...2e1402c. Read the comment docs.

@orbeckst orbeckst self-assigned this Sep 15, 2021
@orbeckst
Copy link
Member

Thanks @xiki-tempula !

@IAlibay do the latest changes address your concerns?

Copy link
Member

@IAlibay IAlibay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, just the one thing about the docs authorship

@@ -22,3 +22,4 @@ Contributors:
* Lily Wang <lilyminium>
* Josh Vermaas <jvermaas>
* Irfan Alibay <IAlibay>
* Zhiyi Wu <xiki-tempula>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I found out that the docs don't auto-populate the authors list, could you also add yourself to conf.py in the docs please?

@orbeckst orbeckst merged commit 5d32227 into MDAnalysis:master Sep 17, 2021
@xiki-tempula xiki-tempula deleted the patch-1 branch September 17, 2021 07:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use scientific notation for the delta representation
4 participants