-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add more digits to the delta of openDX #89
Conversation
Hello @xiki-tempula! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found: There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻 Comment last updated at 2021-09-15 22:17:02 UTC |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If you update against master CI should now be green (hopefully?)
I'll let @orbeckst do the final review here (since I'm technically new to this repo).
I think you need to add yourself to AUTHORS?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR, @xiki-tempula ; please add
- CHANGELOG
- AUTHORS
- small test that checks that the guaranteed number of digits is saved (and read) — maybe just use your example
- add entry to docs for OpenDX stating how we are saving (for instance, for PyMOL we have an entry on precision)
Codecov Report
@@ Coverage Diff @@
## master #89 +/- ##
=======================================
Coverage 87.59% 87.59%
=======================================
Files 5 5
Lines 814 814
Branches 118 118
=======================================
Hits 713 713
Misses 60 60
Partials 41 41
Continue to review full report at Codecov.
|
Thanks @xiki-tempula ! @IAlibay do the latest changes address your concerns? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm, just the one thing about the docs authorship
@@ -22,3 +22,4 @@ Contributors: | |||
* Lily Wang <lilyminium> | |||
* Josh Vermaas <jvermaas> | |||
* Irfan Alibay <IAlibay> | |||
* Zhiyi Wu <xiki-tempula> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I found out that the docs don't auto-populate the authors list, could you also add yourself to conf.py in the docs please?
Fix #88