Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix multiple __init__ calls #74

Merged
merged 2 commits into from
Jan 17, 2020

Conversation

eloyfelix
Copy link
Contributor

Fixes #73

@codecov
Copy link

codecov bot commented Nov 30, 2019

Codecov Report

Merging #74 into master will increase coverage by 0.03%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #74      +/-   ##
==========================================
+ Coverage   87.34%   87.37%   +0.03%     
==========================================
  Files           5        5              
  Lines         798      800       +2     
  Branches      118      118              
==========================================
+ Hits          697      699       +2     
  Misses         60       60              
  Partials       41       41
Impacted Files Coverage Δ
gridData/core.py 94.2% <100%> (+0.04%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7a76d62...1bf3aec. Read the comment docs.

Copy link
Member

@orbeckst orbeckst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! (I just added you to the CHANGELOG)

(Apologies for forgetting to review the PR – in the future please feel free to ping me and ask for a review. I won't get mad.)

@orbeckst orbeckst merged commit cf8ed57 into MDAnalysis:master Jan 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

multiple Grid __init__ calls can break extended Grid classes
2 participants