Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support Python 3.10 #101

Closed
orbeckst opened this issue Dec 30, 2021 · 5 comments · Fixed by #105
Closed

support Python 3.10 #101

orbeckst opened this issue Dec 30, 2021 · 5 comments · Fixed by #105
Labels
CI continuous integration infrastructure Python3 testing
Milestone

Comments

@orbeckst
Copy link
Member

Enable testing for Python 3.10 (and fix anything that needs fixing).

@orbeckst orbeckst added CI continuous integration infrastructure Python3 testing labels Dec 30, 2021
@IAlibay
Copy link
Member

IAlibay commented Dec 30, 2021

Given the recent issues with six in the core library (highlighting this library as one of the core dependencies still requiring it), is it worth revisiting its use?

Looking at their issue tracker, I think there's a fix for py3.10 for six but it's probably not coming for some time.

@orbeckst
Copy link
Member Author

orbeckst commented Dec 30, 2021 via email

@orbeckst orbeckst mentioned this issue Dec 30, 2021
3 tasks
@orbeckst orbeckst added this to the 0.7.0 milestone Dec 30, 2021
@orbeckst orbeckst mentioned this issue Dec 30, 2021
5 tasks
@orbeckst
Copy link
Member Author

Is six not working with 3.10?

if that’s the case then my comment in #102 to drop legacy for 1.0 is moot — we do want to support 3.10 asap.

@IAlibay
Copy link
Member

IAlibay commented Dec 30, 2021

I've not had time to really dig into it - there's a bunch of warnings that could be problematic, but it hasn't affected the outcome of the MDA testsuite, so whatever it's affecting isn't impacting most things probably?

@IAlibay
Copy link
Member

IAlibay commented Feb 20, 2022

I think six is now working again with py3.10 (see v1.16.0 in https://github.com/benjaminp/six/blob/master/CHANGES).

As far as I can tell the six code isn't regularly tested with py3.10, but we can see what happens?

orbeckst added a commit that referenced this issue Feb 20, 2022
- add 3.10 support (from #101)
- cleaned up whitespace
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI continuous integration infrastructure Python3 testing
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants