Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Whitelist command signature change #52

Closed
mbicknese opened this issue Nov 2, 2023 · 4 comments
Closed

Whitelist command signature change #52

mbicknese opened this issue Nov 2, 2023 · 4 comments

Comments

@mbicknese
Copy link

It looks like this project can no longer be built due to GeyserMC/Floodgate#456 being merged. The WhitelistUtils.addPlayer method now expects SpigotVersionSpecificMethods as the third argument.

@rtm516
Copy link
Member

rtm516 commented Nov 2, 2023

You can use the pre-built version on the GitHub release and disable that feature. I can look into fixing this but in all likelihood I will remove it as it's not really a supported use of floodgate.

@mbicknese
Copy link
Author

Oh, that's fine.

I was actually trying to solve a bug I'm having with running the extension in Docker. My guess is that it's not picking up on the correct IP address. I'll figure that out (or create a build with a hardcoded IP if really needed).

Just wanted to let you know building is not currently possible.

@rtm516
Copy link
Member

rtm516 commented Nov 2, 2023

There is remote-address and remote-port in the config to change it if not automatically picked up. Also bedrock doesn't like if the server is listening on a different port to what you connect on, it can cause issues.

@Tim203
Copy link
Member

Tim203 commented Nov 5, 2023

Yeah it wasn't really intended to be used externally. But if there is an use-case then I'm fine with exposing an API for it.

@rtm516 rtm516 closed this as completed in f61df47 Dec 16, 2023
rtm516 added a commit that referenced this issue Dec 16, 2023
This feature is broken and not really something the tool should be doing
Fixes #52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants