Fix bug related to issue #103 #108
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With Sage 8.6, residue fields of valuations on function fields are now function fields themselve, if this makes sense. However, the constant base field may not be a *true* finite field (this is trac:26103). This resulted in an error message when applying the method ``make_function_field``. Now ``make_function_field`` creates a new function field with the right kind of constant base field if the input is already a function field.
|
At the moment it is not possible to pass all test for 8.3 and 8.4 and the current version. |
|
At the moment it is not possible to pass all test for the current version of Sage, and for 8.3 and 8.4. I ignore this issue for the moment, and merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With Sage 8.6, residue fields of valuations on function fields are now
function fields themselves, if this makes sense. However, the constant
base field may not be a true finite field (this is trac:26103). This
resulted in an error message when applying the method
make_function_field.Now
make_function_fieldcreates a new function field with the rightkind of constant base field if the input is already a function field.