Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GH-800: Drain the Pipeline #450

Open
wants to merge 65 commits into
base: master
Choose a base branch
from
Open

GH-800: Drain the Pipeline #450

wants to merge 65 commits into from

Conversation

utkarshg6
Copy link
Collaborator

No description provided.

@utkarshg6
GH-800: Write the most basic TODOs for this card
4cfa253
@utkarshg6
GH-800: Add todos for renaming purposes
07cfef9
@utkarshg6
GH-800: Add a message scheduler for purging the stream key
62db40f
@utkarshg6
GH-800: Improve the test handle_client_response_payload_purges_stream…
e4199ae 
…_keys_for_terminal_response
@utkarshg6
GH-800: Make delay configurable via constant
ee8f897
@utkarshg6
GH-800: introduce StreamSenders
91323d4
@utkarshg6
GH-800: introduce channel for shutdown signal
7cc2fbb
@utkarshg6
GH-800: add test connection_shutdown_test.rs
d784157
@utkarshg6
GH-800: test drive the shutdown signal in StreamReader
14a5de3
@utkarshg6
GH-800: refactor test stream_reader_shuts_down_when_it_receives_the_s…
d8d1f10 
…hutdown_signal
@utkarshg6
GH-800: some refactor inside the file stream_reader
ddf7d9c
@utkarshg6
GH-800: some more refactoring
a6f2538
@utkarshg6
GH-800: trying_to_write_a_test_for_stream_senders was a success
130a37c
@utkarshg6
GH-800: did some refactoring for trying_to_write_a_test_for_stream_se…
6db4c0c 
…nders
@utkarshg6
GH-800: stream_handler_pool_sends_shutdown_signal_when_last_data_is_t…
c3cc6a8 
…rue passes for the first time
@utkarshg6
GH-800: Minor refactor for the test stream_handler_pool_sends_shutdow…
75edd8f 
…n_signal_when_last_data_is_true
@utkarshg6
GH-800: more refactoring of the test stream_handler_pool_sends_shutdo…
296f449 
…wn_signal_when_last_data_is_true
@utkarshg6
GH-800: stream_handler_pool_sends_shutdown_signal_when_last_data_is_t…
a2c763d 
…rue is working fine
@utkarshg6
GH-800: some more todos removed
3c223ea
@utkarshg6
GH-800: clean_up_dead_streams_logs_when_the_shutdown_channel_is_down …
4605d83 
…is passing
@utkarshg6
GH-800: tests are passing in StreamHandlerPool
e1417c8
@utkarshg6
GH-800: Wrote a test for the case when the shutdown signal channel is…
6e28ff1 
… gone
@utkarshg6 utkarshg6 linked an issue Jul 22, 2024 that may be closed by this pull request
Drain the Pipeline MASQ-Project/MASQ-Node-issues#800
Open
@utkarshg6 utkarshg6 marked this pull request as ready for review September 10, 2024 07:53
dnwiebe
dnwiebe reviewed Sep 11, 2024
View reviewed changes
node/src/proxy_client/stream_reader.rs Outdated Show resolved Hide resolved
node/src/proxy_server/mod.rs Outdated Show resolved Hide resolved
node/src/proxy_server/mod.rs Show resolved Hide resolved
node/src/proxy_server/mod.rs Show resolved Hide resolved
node/src/proxy_server/mod.rs Outdated Show resolved Hide resolved
node/src/proxy_server/mod.rs Show resolved Hide resolved
node/tests/connection_shutdown_test.rs Outdated Show resolved Hide resolved
node/src/proxy_client/stream_handler_pool.rs Outdated Show resolved Hide resolved
node/src/proxy_client/stream_handler_pool.rs Outdated Show resolved Hide resolved
node/src/proxy_client/stream_handler_pool.rs Outdated Show resolved Hide resolved
@utkarshg6 utkarshg6 linked an issue Sep 17, 2024 that may be closed by this pull request
ProxyClient should heed instruction to shut up MASQ-Project/MASQ-Node-issues#801
Open
dnwiebe
dnwiebe reviewed Sep 17, 2024
View reviewed changes
node/src/proxy_server/mod.rs Outdated Show resolved Hide resolved
node/src/proxy_server/mod.rs Outdated Show resolved Hide resolved
node/src/proxy_server/mod.rs Show resolved Hide resolved
dnwiebe
dnwiebe reviewed Sep 18, 2024
View reviewed changes
node/src/proxy_server/mod.rs Outdated Show resolved Hide resolved
node/src/proxy_server/mod.rs Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dnwiebe dnwiebe dnwiebe approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

ProxyClient should heed instruction to shut up Drain the Pipeline
3 participants
@utkarshg6 @dnwiebe @kauri-hero