Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GH-672: payment adjuster infrastructure #348

Merged
merged 112 commits into from
Oct 13, 2023
Merged

GH-672: payment adjuster infrastructure #348

merged 112 commits into from
Oct 13, 2023

Conversation

bertllll
Copy link
Contributor

No description provided.

Bert added 30 commits May 4, 2023 18:32
GH-554: rough infrastructure for PaymentAdjuster; almost get first ro…
81eec66 
…und test running
GH-672: simplifying GH-554, let's go on without the Neighborhood invo…
6961653 
…lved for the time being
GH-672: PaymentAdjusterMock and the supertrait with ScannerEtensions …
a60c3ae 
…implemented for a try
GH-672-with-trait-impl-and-generics: perhaps going in the right direc…
bae8ba7 
…tion
GH-672-best-methodology-found: implementation works
752364c
GH-672: first version of adjustment implemented
a63b4a3
GH-672: finished implementing the main test; not refactored yet
279c2a0
GH-672: payment adjuster refactored; tuning logging; but wanna master…
f51de9b 
… features that are missing here
GH-672: master got in now
d99fd45
GH-672: some logging integrated
0a7dc32
GH-672: fine debug log
89dc99a
GH-672: interim commit
d448ece
GH-672: interim commit
0f45f2e
GH-672: another package of big changes (partly-private msgs; payment …
a0f22c3 
…adjuster)
GH-672: decent debug log for adjusted payables
b076bee
GH-672: broadening the adjustment capabilities with gas; rough framework
58db009
GH-672: savepoint; before experimenting with early gas_limit computation
8f5c604
GH-672: continuing in implementation of the check for gas availability.
557c51f
GH-672: merged master in
f5ab24e
GH-672: some renaming and moving files
5547fda
GH-672: almost completed but there is a cenceptual error; maybe extra…
4c322ae 
… tests for BlockchainInterfaceClandestine should be made first
GH-672: last details; adding tests for untested code from BlockchainI…
05eb924 
…nterfaceClandestine
GH-672: almost done; some refactoring ahead
87b7ac9
GH-672: heading to auto-review
ab0b1d8
GH-672: auto review findings
2545ca9
GH-672: refactored scan scheduling code
66a5b54
GH-672: fixing issues from the review; save point before the shift of…
f0a8515 
… responsibility of the estimated gas limit from BchI to Chain
GH-672: before connecting the early fetched gas price and the actual …
0adbd77 
…gas price used for generating hashed transactions
GH-672: logic redesigned + renaming
e3c433a
GH-672: I believe the first review is answered by now
9d6c959
Bert and others added 20 commits October 3, 2023 22:50
GH-672: merge with GH-600 completed
79e8c86
GH-672: renamings and moves in test code
76edf01
GH-672: rpc halpers into lower level interface
142985e
@masqrauder
Squashing:
6530e4d 
GH-600: Add get_block_number
GH-600: Address PR feedback
GH-585: Experiment with adapting test for platform specific error codes
GH-585: Provide Windows platform specific error code and message
GH-600: Rebase master into branch
@masqrauder
GH-600: Handle expected batch, got single response
4876be3
@masqrauder
Resolve rebase issues
1e20aa6
@masqrauder
GH-600: Adapt to new Pokt message changes
094f0b3
@masqrauder
Use start_block in the event of an error
1fa8c4d
@masqrauder
GH-600: Return blockchain scan error to update max_block_count
66eff5a
@masqrauder
GH-600: Resolve blockchain scanning
b9054da 
* Starts Accountant
* Adds Receivables scan timeout (may become a configuration parameter in another card)
* Stores `max_block_count` in the config table when processing error messages providing a limit
* Adds Max Block Count to configuration response
* Increments CURRENT_SCHEMA_VERSION
* Adds schema migration for `max_block_count`
* Improves blockchain scan error handling and logging
@masqrauder
GH-600: Add test for scan time out
b4a4fca
@masqrauder
GH-600: Revert scanner changes
71bc0ce
@masqrauder
GH-600: Address review feedback
d101ff5
GH-672: incorporated new changes from GH-600
830e9e8
GH-672: ending a big rearrangement; stable with all the tests again
d266940
GH-672: more refactoring
02a897e
GH-672: missing import
2c96728
GH-672: review 7 answered
d7f91bb
GH-672: merged master in
0d4d6a3
GH-672: removed a not suitable comment
69a4870
utkarshg6
utkarshg6 reviewed Oct 11, 2023
View reviewed changes
Copy link
Collaborator

@utkarshg6 utkarshg6 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have reviewed the modifications in the following commits, and they exclusively involve straightforward name changes that are more generic in nature.

bertllll
bertllll commented Oct 13, 2023
View reviewed changes
node/src/blockchain/blockchain_bridge.rs Outdated
self.handle_scan(
Self::handle_request_balances_to_pay_payables,
Self::handle_payable_payments_setup_msg_payload,
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bad name

node/src/blockchain/blockchain_interface/blockchain_interface_web3/mod.rs Show resolved Hide resolved
node/src/node_configurator/configurator.rs Outdated Show resolved Hide resolved
node/src/node_configurator/configurator.rs Outdated Show resolved Hide resolved
node/src/node_configurator/configurator.rs Outdated Show resolved Hide resolved
node/src/node_configurator/configurator.rs Outdated Show resolved Hide resolved
utkarshg6
utkarshg6 approved these changes Oct 13, 2023
View reviewed changes
Copy link
Collaborator

@utkarshg6 utkarshg6 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🫠

@bertllll bertllll merged commit b2d0b07 into master Oct 13, 2023
7 checks passed
@bertllll bertllll deleted the GH-672 branch October 13, 2023 14:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@utkarshg6 utkarshg6 utkarshg6 approved these changes

@dnwiebe dnwiebe dnwiebe approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@bertllll @dnwiebe @utkarshg6 @masqrauder