GH-691: Review 1 #300
Merged
GH-691: Review 1 #300
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bertllll
reviewed
Jun 15, 2023
* GH-691: rename min_hops_count to min_hops everywhere * GH-691: implement the computed_default() * GH-691: implement the computed_default() for min hops * GH-691: replace min hops value to the the one in db * GH-691: rename DEFAULT_MIN_HOPS_COUNT and MIN_HOPS_COUNT_FOR_TEST to DEFAULT_MIN_HOPS and MIN_HOPS_FOR_TEST respectively * GH-691: remove unnecessary test * GH-691: Review 3 (#304) * GH-691: convert panic into error log inside the setup_reporter.rs * GH-691: use Default instead of Configured if the default min hops value is found in db * GH-691: change debug to info in the validation * GH-691: use AssertionsMessage for asserting when the validation does not need to replace the value * GH-691: remove use of min_hops_params from the tests in Neighborhood * GH-691: remove min_hops_params * GH-691: fix typo in test name * GH-691: improve the log statement
utkarshg6
added a commit
that referenced
this pull request
Jul 11, 2023
* GH-691: database migration for 7 to 8 * GH-691: update CURRENT_SCHEMA_VERSION to 8 * GH-691: add test to set the min_hops_count inside PersistentConfiguration * GH-691: fix tests in actor_system_factory.rs * GH-691: add the ability to retrieve value of min_hops_count from the database * GH-691: add tests for validating min hops count * GH-691: test drive code for validating the min_hops_count value from the persistent configuration * GH-691: minor code improvements * GH-691: remove second declaration of CURRENT_SCHEMA_VERSION * GH-691: remove unnecessary comments * GH-691: improve validate_database_min_hops_count() * GH-691: fixed test cleanup_after_deceased_clients_integration * GH-691: add todos to where we should set the min_hops_count * GH-691: set min_hops_count value inside configure_database() * GH-691: remove code for setting min_hops_count inside actor_system_factory.rs * GH-691: set min_hops_count default value while initializing database * GH-691: change how min_hops_count is handled inside make_neighborhood_config() * GH-691: instead of defaulting min_hops_count inside clap, default it in db * GH-691: feed min_hops_count value inside ConfigDaoNull * GH-691: add test for checking whether the node panics when the min_hops_count value is not found * GH-691: remove clippy warnings * GH-691: remove redundant code * GH-691: more improvements to validate_database_min_hops_count() * GH-691: Review 1 (#300) * GH-691: minor changes in persistent_configuration.rs * GH-691: Display for Hops can be simplified * feat: panic when value of min_hops_count is not present in db * GH-591: remove setting a result for set_min_hops_count inside actor_system_factory.rs * GH-691: improvements in migration_7_to_8.rs * fix: the todo has been changed to a comment after discussion in the dev team * GH-691: Review 2 (#302) * GH-691: rename min_hops_count to min_hops everywhere * GH-691: implement the computed_default() * GH-691: implement the computed_default() for min hops * GH-691: replace min hops value to the the one in db * GH-691: rename DEFAULT_MIN_HOPS_COUNT and MIN_HOPS_COUNT_FOR_TEST to DEFAULT_MIN_HOPS and MIN_HOPS_FOR_TEST respectively * GH-691: remove unnecessary test * GH-691: Review 3 (#304) * GH-691: convert panic into error log inside the setup_reporter.rs * GH-691: use Default instead of Configured if the default min hops value is found in db * GH-691: change debug to info in the validation * GH-691: use AssertionsMessage for asserting when the validation does not need to replace the value * GH-691: remove use of min_hops_params from the tests in Neighborhood * GH-691: remove min_hops_params * GH-691: fix typo in test name * GH-691: improve the log statement * GH-691: fix the remaining renames (#312)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.