Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GH-631: Gossip Storm Avoidance #196

Merged
merged 36 commits into from
Dec 13, 2022
Merged

GH-631: Gossip Storm Avoidance #196

merged 36 commits into from
Dec 13, 2022

Conversation

utkarshg6
Copy link
Collaborator

No description provided.

utkarshg6 and others added 30 commits October 31, 2022 13:01
@utkarshg6
GH-631: get the skeleton ready
63f74ab
@utkarshg6
GH-631: add a working recursive method for computing patch
4d38ea0
@utkarshg6
GH-631: add test for computing patch; not working yet
5d95637
@utkarshg6
GH-631: improve the test for the compute_patch function and make it w…
507f0af 
…orking
@utkarshg6
GH-631: refactor the recursive function to compute patch
36c466a
@utkarshg6
GH-631: refactor the conditionals inside the recursion
280b3b2
@utkarshg6
GH-631: refactor the compute_patch() to use match
8f8b28f
@utkarshg6
GH-631: compute_patch() should search for neighbors in it's database …
8277905 
…for the root node
@utkarshg6
GH-631: improve the solution for the compute_patch()
3f8fd66
@utkarshg6
GH-631: minor code cleanup
e2f9922
@utkarshg6
GH-631: add one more test to make compute_patch() robust
00270a3
@utkarshg6
GH-631: add one more test for compute_patch()
83ab0f3
@utkarshg6
GH-631: reduce the number of recursion calls and minize hashset size
cad6695
@utkarshg6
GH-631: add test to check if the standard gossip handler ignores goss…
c4143b9 
…ips that are outside the patch
@utkarshg6
GH-631: make the test work
541260c
@utkarshg6
GH-631: fix the test proper_standard_gossip_is_matched_and_handled
325f1a7
@utkarshg6
GH-631: fix the tests inside gossip_acceptor.rs
92a8eb9
@utkarshg6
GH-631: refactor the compute_patch()
6a2f92f
@utkarshg6
GH-631: remove compiler warnings
18191a0
@utkarshg6
GH-631: filter agrs before calling the function that'll add introduct…
d1281af 
…ory node
@utkarshg6
GH-631: only use references to build hashmap from agr
663ba06
@utkarshg6
GH-631: use constant for computing patch
ad33fad
@utkarshg6
GH-631: remove redundant code
fff58c8
@utkarshg6
GH-631: remove clippy warnings
53bd30a
@utkarshg6
GH-631: rename test to can_retrieve_all_full_and_half_neighbors()
0588c33
@utkarshg6
GH-631: remove contract test for eth ropsten
7e9dcac
@utkarshg6
GH-631: modify extract_node_reference()
6651717
@dnwiebe
GH-631: Did more fixing on the blockchain multinode test
8a8b1a4
@utkarshg6
GH-631: format the code
446b17b
@masqrauder @utkarshg6
GH-600: Workaround multinode test libc failure
81f404c
dnwiebe
dnwiebe reviewed Dec 5, 2022
View reviewed changes
Copy link
Collaborator

@dnwiebe dnwiebe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Resume at gossip_acceptor.rs:3558 green.

node/src/neighborhood/mod.rs Outdated Show resolved Hide resolved
node/src/neighborhood/neighborhood_database.rs Outdated Show resolved Hide resolved
node/src/neighborhood/neighborhood_database.rs Outdated Show resolved Hide resolved
node/src/neighborhood/gossip_acceptor.rs Outdated Show resolved Hide resolved
node/src/neighborhood/gossip_acceptor.rs Outdated Show resolved Hide resolved
node/src/neighborhood/gossip_acceptor.rs Show resolved Hide resolved
node/src/neighborhood/gossip_acceptor.rs Outdated Show resolved Hide resolved
node/src/neighborhood/gossip_acceptor.rs Outdated Show resolved Hide resolved
node/src/neighborhood/gossip_acceptor.rs Show resolved Hide resolved
node/src/neighborhood/gossip_acceptor.rs Show resolved Hide resolved
utkarshg6 and others added 6 commits December 12, 2022 17:25
@utkarshg6
GH-631: Review 1 (#202)
7d3e8d3 
* GH-631: refactor the compute_patch()

* GH-631: use node record instead of database

* GH-631: rename the some_node into not_a_neighbor

* GH-631: create an outboard function for creating patch

* GH-631: make a function for filtering agrs

* GH-631: remove unused functions

* GH-631: refactor test in gossip_acceptor.rs

* GH-631: minor changes in gossip_acceptor.rs

* GH-631: write test gossip_acceptor_filters_out_the_node_addr_of_incoming_gossip; not working yet

* GH-631: remove the test that you've recently written

* GH-631: Review 1 changes
@utkarshg6
GH-631: remove clippy warnings
5d29f26
@masqrauder @utkarshg6
GH-633: change the version number of libc from 2.36-4 to 2.36-6
bf1cf1c
@utkarshg6
Trigger Build
cfbb1f7
@utkarshg6
GH-631: An attempt to fix multinode test provided_and_consumed_servic…
64cfa77 
…es_are_recorded_in_databases() by using duration
@utkarshg6
GH-631: remove the clippy allow statement for the compute_patch_recur…
d4e125e 
…sive()
@bertllll bertllll merged commit e0bd8e3 into master Dec 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dnwiebe dnwiebe dnwiebe left review comments

@bertllll bertllll bertllll approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@utkarshg6 @dnwiebe @bertllll @masqrauder