-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add filter component and functionality #75
Conversation
stac_browser_url = self.stac_data["collection"]["href"].replace("https://", "https://stac-browser.maap-project.org/external/") | ||
stac_browser_url = self.stac_data["collection"]["href"].replace( | ||
"https://", "https://stac-browser.maap-project.org/external/" | ||
) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💭 : I'm realizing that alot of these changes are probably due to the black formatter lol. But i'm thinking https://stac-browser.maap-project.org/external/
is a good candidate as a constant
Nice job on getting this quickly done 🙌🏼 💭 🧪 : I'm wondering when do we want to start adding tests with our changes in PRs? This change looks like it would be a good candidate to unit test but we dont have testing set up right now. I'm worried we would keep adding code and functionality creating a longer list of things to test in the future. Should we just start adding tests to our PR or we can come together and think of how to start implementing tests real soon! |
I think you're right - perhaps we should start integrating tests before the backlog of testing increases further. I do think it was important to make good progress on a feature in the interest of the overall sprint, so perhaps we can pause on implementing other features, and continue our focus to tidy-up: including testing, and perhaps some of the UI improvements we'll talk about later today. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Summary:
STAC_v7_STAC_Filtered.mov
Fixes or Addresses Issue #: #66
Checklist before requesting a review: