Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

changed to use pip install #99

Merged
merged 3 commits into from
Mar 20, 2024
Merged

changed to use pip install #99

merged 3 commits into from
Mar 20, 2024

Conversation

marjo-luc
Copy link
Member

@marjo-luc marjo-luc commented Mar 19, 2024

  • updated package installation to use pip install
  • umf extension has been removed since the CMR metadata form is no longer used and there is no equivalent to take its place

@marjo-luc marjo-luc marked this pull request as ready for review March 20, 2024 14:19
@marjo-luc marjo-luc requested a review from grallewellyn March 20, 2024 14:19
Copy link
Contributor

@grallewellyn grallewellyn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving because all extensions work when I tested in our shared workspace test-3.1.5 which was built off the maap-workspaces:feature/install-updates branch.
A couple things I noticed that were problems before and not affected by this PR:

  1. Testing all the extensions, one thing I notice is that I see my own jobs in view jobs (for a shared workspace with Marjorie that she owns), so the Output open in file browser button doesn’t work for successfully completed jobs because it is trying to access something in my private bucket which Marjorie doesn’t have access to
    It makes sense Marjorie shouldn’t have access to my private bucket
    And we want me to see my own jobs in our shared workspace, right?
    So maybe there is nothing to do here because I am properly notified that I cannot navigate to something in my private bucket
  2. The link that I get for “Copy Download link” for a file in my private bucket doesn’t work

@marjo-luc
Copy link
Member Author

  1. Confirmed that this is the expected behavior.
  2. This looks like a DIT-specific issue. Bug ticket created to track it.

@marjo-luc marjo-luc merged commit 42ded71 into main Mar 20, 2024
@marjo-luc marjo-luc deleted the feature/install-updates branch March 20, 2024 17:17
grallewellyn added a commit that referenced this pull request Mar 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update workspace jupyterlab extension installation commands
2 participants