-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/remove collaboration #53
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, please add a ticket with a link to relevant Jupyterlab issue to remind us to keep tabs on how they resolve it upstream.
Relevant issues: |
might also fix: https://github.com/orgs/MAAP-Project/discussions/784 |
@rtapella Yes, this should fix: https://github.com/orgs/MAAP-Project/discussions/784 |
Removed the collaboration tag from launching jupyter notebook because it was causing blank notebook errors and jumping errors within the cells
Tested this successfully 5 times with 5 notebooks in R and and 5 times with 5 notebooks in vanilla, following these steps:
Also tested this successfully in jupyterlab 3.6.4 5 times with 5 notebooks in R and and 5 times with 5 notebooks in vanilla, but I think we should avoid bumping the jupyterlab version if possible
People should test this if they can to confirm the errors have gone away
Pipeline created here with all successful image builds: https://repo.dit.maap-project.org/root/maap-workspaces/-/pipelines/2876
Can test in DIT using the branch name
remove-collaboration
. I confirmed all 6 base images build successfully in DIT