Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/remove collaboration #53

Merged
merged 11 commits into from
Jun 22, 2023
Merged

Conversation

grallewellyn
Copy link
Contributor

Removed the collaboration tag from launching jupyter notebook because it was causing blank notebook errors and jumping errors within the cells
Tested this successfully 5 times with 5 notebooks in R and and 5 times with 5 notebooks in vanilla, following these steps:

  1. Create a new notebook and add some content. Make sure no jumping error
  2. Save notebook
  3. Stop and restart workspace
  4. Open notebook back up and make sure it isn't just a blank screen

Also tested this successfully in jupyterlab 3.6.4 5 times with 5 notebooks in R and and 5 times with 5 notebooks in vanilla, but I think we should avoid bumping the jupyterlab version if possible

People should test this if they can to confirm the errors have gone away

Pipeline created here with all successful image builds: https://repo.dit.maap-project.org/root/maap-workspaces/-/pipelines/2876

Can test in DIT using the branch name remove-collaboration. I confirmed all 6 base images build successfully in DIT

Copy link
Contributor

@gchang gchang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, please add a ticket with a link to relevant Jupyterlab issue to remind us to keep tabs on how they resolve it upstream.

@grallewellyn
Copy link
Contributor Author

Relevant issues:
jupyterlab/jupyterlab#14278
jupyterlab/jupyterlab#13930 (comment) (but this one is supposed to be resolved)

@grallewellyn grallewellyn merged commit ba2eb92 into develop Jun 22, 2023
@grallewellyn grallewellyn deleted the feature/remove-collaboration branch July 12, 2023 22:24
@rtapella
Copy link

rtapella commented Aug 2, 2023

fixes MAAP-Project/Community#735

@rtapella
Copy link

rtapella commented Aug 7, 2023

@grallewellyn
Copy link
Contributor Author

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants