This repository has been archived by the owner on Sep 6, 2019. It is now read-only.
Ui improvement : moved help into the action bar + ability to hide filters #532
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
M66B
added a commit
that referenced
this pull request
Aug 18, 2013
Ui improvement : moved help into the action bar + ability to hide filters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
++ Moved the help button to the action bar
++ Moved the edit help (pen icon) into the help pop-up (only for the main activity)
++ Added scrollbars to the main help pop-up in order to avoid cut content on small screens
++ Added a frame around the filter section
++ Ability to show/hide the filter section (hidden when the application starts)
++ Added two strings (filter title + help menu)
--- Removed two images :
-> the pen is no longer useful,
-> the question mark is now taken from the system in order to be displayed at the good scale in the action bar
Note :
I have been forced not to use a plural string for the filter title because the 'zero' case is bugged in Android. I used a formatted MessageFormat instead, you only have to translate the bold words :
{0,choice,0#No active filter|1#1 active filter|1<{0} actives filters}
The diff files for the layouts are really messy because I changed the order of the components and the layout tree.