This repository has been archived by the owner on Sep 6, 2019. It is now read-only.
Whitelisting extras #1401
Merged
Whitelisting extras #1401
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| public static Boolean checkWhitelist(int uid, String type, String name, boolean useCache) { | ||
| // For getRestriction we need to be able to indicate whether it is | ||
| // whitelisted, blacklisted, or not stored. | ||
| String value = PrivacyManager.getSetting(uid, type + "." + name, "", useCache); |
There was a problem hiding this comment.
Why not use null as default value to simplify the check for empty settings?
There was a problem hiding this comment.
Because reading a string from an sqlite db where the stored value is null, might or might not work depending on the implementation of sqlite. (That's roughly what the android docs say.)
There was a problem hiding this comment.
Then we should later the column to be not nullable.
I will see if this is possible and take care of it.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I trust that the settings and restrictions caches deal with any performance issues and don't introduce any bugs. I haven't tested that aspect thoroughly, but it seems to work.
I have added a dialog in ActivityApp for managing the different types of whitelists. One aspect that might seem counter-intuitive is that you have to check to allow. This is similar to the allowed Accounts, Contacts and App, but dissimilar to the logic of restricting elsewhere. It might be wise to change this.
Currently the dialog uses the values of cWhitelistWhatever for the whitelist types, there is, as yet, no provision for using localised values.
Refs #1375