Skip to content
This repository has been archived by the owner on Sep 6, 2019. It is now read-only.

XPrivacy new app notification clicks through to last viewed app, not new app #777

Closed
Jimmy34742 opened this issue Nov 16, 2013 · 16 comments
Closed
Labels

Comments

@Jimmy34742
Copy link
Contributor

Reproduced every time, including 1.10.16:

  1. open XPrivacy and click on App1 to view its list of restriction
  2. press home button
  3. load Play Store app
  4. install App2
  5. when the install completes, XPrivacy's new app notification correctly displays the App2's name in Notifications
  6. press XPrivacy's new app notification for App2
  7. XPrivacy opens to the last context, which is the list of restrictions for App1, not App2. XPrivacy's notification is removed
@M66B
Copy link
Owner

M66B commented Nov 16, 2013

I can reproduce it, but I don't know yet how to fix it.
All fixes in this area resulted in breaking something else (like up navigation) so far.

@Jimmy34742
Copy link
Contributor Author

It's only a minor inconvenience. But if the user doesn't pay attention and just assumes XPrivacy is showing the new app, restrictions could get altered unintentionally. I've done that more than once. If the bug can't be fixed, maybe it would be better for XPrivacy's new app notification to take the user to the top of XPrivacy and display the progress percentage that shows all the apps loading so that the user can't be misled as to the context.

I've also had XPrivacy FC a few times after pressing its new app notification and then switching apps via some non-stock methods. For example, GMD Gesture Control provides its own running tasks list. If I can find a reproducible pattern to the FC's, I'll post here.

@M66B
Copy link
Owner

M66B commented Nov 16, 2013

I will fix this somehow.

@M66B
Copy link
Owner

M66B commented Nov 16, 2013

Could you please check if this version solves the problem and if there are no side effects: http://d-h.st/WMN

@Jimmy34742
Copy link
Contributor Author

After a couple of tests, the problem looks fixed. I haven't seen any side effects. I should mention I'm still seeing a second instance of XPrivacy in my popup task manager. I didn't mention it before because it's not the Android stock task manager. I don't know if it's relevant now.

I did notice the border around the icons in the app list--looks good. Unfortunately, some apps' icons use up all the pixels so that the border isn't visible.

@M66B
Copy link
Owner

M66B commented Nov 17, 2013

Thanks for reporting back.

@ghost
Copy link

ghost commented Nov 17, 2013

@Jimmy34742 I'm looking into the dual instance of XPrivacy inside Android task switcher problem, must have something to do with all these Activities attributes, I'm getting some clue but I need to ensure I won't break anything. if I find a possible solution, would you like to help me test it out?

@M66B
Copy link
Owner

M66B commented Nov 17, 2013

@jokies are the dual instances for the same activity?

@ghost
Copy link

ghost commented Nov 17, 2013

No. Obviously one is for the .ActivityMain and one is for the .ActivityApp.
The problem is so far all the possible solutions I came up with might affect the Activity life cycle, not like the noHistory attribute.

Jokiestrunk∈Internet
CRS-Sys.

On Nov 18, 2013, at 1:15 AM, Marcel Bokhorst [email protected] wrote:

@jokies are the dual instances for the same activity?


Reply to this email directly or view it on GitHub.

@M66B
Copy link
Owner

M66B commented Nov 17, 2013

@jokies
This is normal Android behavior and should not be changed.
You can jump directly to the main application list and the application details view this way.

@ghost
Copy link

ghost commented Nov 17, 2013

Ok, but I find it a little weird since not much apps doing so. Besides
that's a little confusing since they both have the "XPrivacy" as title.

2013/11/18 Marcel Bokhorst [email protected]

@jokies https://github.com/jokies
This is normal Android behavior and should not be changed.
You can jump directly to the main application list and the application
details view this way.


Reply to this email directly or view it on GitHubhttps://github.com//issues/777#issuecomment-28658771
.

Jokiestrunk∈Internet
Mail checked daily.

@M66B
Copy link
Owner

M66B commented Nov 17, 2013

That can be improved by adding the application name to the title in the application details view.

@ghost
Copy link

ghost commented Nov 17, 2013

Of course you can. Then this is no more considered a problem need to be fixed.

Jokiestrunk∈Internet
CRS-Sys.

On Nov 18, 2013, at 2:15 AM, Marcel Bokhorst [email protected] wrote:

That can be improved by adding the application name to the title in the application details view.


Reply to this email directly or view it on GitHub.

@ghost
Copy link

ghost commented Nov 19, 2013

Just to update that if android:excludeFromRecents="true" attribute was added to the .ActivityApp activity inside manifest, it should no more show up inside Android task switcher.

@M66B
Copy link
Owner

M66B commented Nov 20, 2013

@jokies I don't think we should exclude from recent.

@ghost
Copy link

ghost commented Nov 20, 2013

I understand, I just want to help anybody who seek a solution through github search function.

Jokiestrunk∈Internet
CRS-Sys.

On Nov 20, 2013, at 5:42 PM, Marcel Bokhorst [email protected] wrote:

@jokies I don't think we should exclude from recent.


Reply to this email directly or view it on GitHub.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

2 participants