3.5.8 UI Crash

[an0n981]

The crash occured while scrolling the app list.

Log around the crash: https://gist.github.com/an0n981/e6cb5f1e370d57b64f17
If more logging is needed, I will try to reproduce the issue.

[M66B]

How are you, an0n981?

​Solving one out of memory results into a new out of memory.
Can you please check how much memory you have free?​

[an0n981]

I am alright, how about yourself?

I had around 1.2 GB free at the time of the crash

[M66B]

I am fine, thanks!

I guess you didn't have this problem with 3.5.7 ?
There are not much changes, so you can easily downgrade if you like.

[an0n981]

I don't know if it was caused by 3.5.8 or by TW rom, as I have just switched back to TW from AOSP. I previously had UI crashes with prevuozs XPrivacy versions. I can upload the logs if you would like.

[M66B]

Yes, please, but check first if the cause was an out of memory exception,
in that case that is all I need to know.

[an0n981]

Logs sent via email, seem to not be related to out of memory error

[M66B]

All first crashes in the four log files have as
cause java.lang.OutOfMemoryError.

[M66B]

Might be a consequence of the changes for #2094

[M66B]

Test version:
https://crowd.xprivacy.eu/XPrivacy_3.5.8-1.apk

[an0n981]

Now a lot of the icons don't show in the list view

[M66B]

Probably this: 52d70b0

I will later build a version without this change.

How is the speed?

[an0n981]

Noticably faster. When scrolling and coming to a stop I used to have to wait a second for the list to finish processing, but now it's always ready as soon it stops scrolling.
Also worth noting, only 'Andy the Android' icons don't show up, and not all of them either. All apps with their own icon show up just fine.

[M66B]

Ah, interesting, 'Andy the Android' actually means no icon.
I was thinking about another problem, but I guess it is simpler.

[M66B]

Please try again with this version:
https://crowd.xprivacy.eu/XPrivacy_3.5.8andy.apk

[M66B]

And thanks for testing on this Christmas evening!

[an0n981]

Andy is back!
Testing XPrivacy is much more fun than watching 'Home Alone' for the 800th time, a weird Christmas tradition where I live.

[M66B]

I feel the same about Home alone, etc ;-)
Just boring.

[an0n981]

I have noticed that there are now randomly icons missing while scrolling, when scrolling back through they reappear, there is no logic to which icons don't appear

[M66B]

I guess this version will solve that:
https://crowd.xprivacy.eu/XPrivacy_3.5.8angry.apk

[an0n981]

I liked the Andy version better thab the Angry version

[M66B]

LOL
See, my commit ;-)

[an0n981]

But now he is angry, we are back to him being missing, not as often as before, but still he does seem angry

[M66B]

So, the problem is not fixed?

[an0n981]

It is definitely geitting better, only 3 andys are missng. But no, not fixed completely

[M66B]

Which applications?

[M66B]

I have one angry Andy too.
But is the scrolling issue fixed?

[an0n981]

Yes everything is working great, speed is amazing. The apps are com.samsung.indexservice, com.sec.android.app.SPenKeeper and com.sec.abdroid.providers.tasks.

[M66B]

This version should even be faster and display all icons:
https://crowd.xprivacy.eu/XPrivacy_3.5.8happy.apk

[an0n981]

All the icons are happy again :)

[M66B]

All changes are available in beta version 3.5.9
https://github.com/M66B/XPrivacy/releases/tag/3.5.9