Skip to content
This repository has been archived by the owner on Sep 6, 2019. It is now read-only.

[Question] How is onDemand handled during submition #1438

Closed
an0n981 opened this issue Feb 23, 2014 · 9 comments
Closed

[Question] How is onDemand handled during submition #1438

an0n981 opened this issue Feb 23, 2014 · 9 comments

Comments

@an0n981
Copy link
Contributor

an0n981 commented Feb 23, 2014

For an app that for example needs access to ID/build.prop I have to deny but ask. This way it can only access build.prop when I explicitly allow it. How are these exceptions handled when submitting? Could this setup possibly lead to issues for users with onDemand off?

@M66B
Copy link
Owner

M66B commented Feb 23, 2014

Whitelisted stuff is not submitted and I don't think it is a good idea to submit it, since it could contain privacy sensitive stuff.

@M66B M66B added the question label Feb 23, 2014
@M66B M66B closed this as completed Feb 23, 2014
@M66B
Copy link
Owner

M66B commented Feb 23, 2014

Maybe we should handle this like the accounts, applications and contacts and just submit there are exceptions.

@M66B M66B reopened this Feb 23, 2014
@M66B M66B added enhancement and removed question labels Feb 23, 2014
@an0n981
Copy link
Contributor Author

an0n981 commented Feb 23, 2014

I don't think you understood what I meant.

Example: App XYZ needs access to Internet:inet to function.
My setup for Internet:inet: Deny but ask, then I allow once when needed. This way the app cannot access inet unless I explicitly allow once.

How is this setup handled?

@M66B
Copy link
Owner

M66B commented Feb 23, 2014

It is not handled yet.

@Cerberus-tm
Copy link

So it is basically submitted as "deny"? Or is it not submitted at all because it's different?

@M66B M66B closed this as completed in e1c4c82 Feb 23, 2014
@M66B
Copy link
Owner

M66B commented Feb 23, 2014

This will be changed in the next release, these functions will be submitted as deny with having an exception. While fetching the server will take into account the exceptions (and basically allow the restriction). Later we can improve this, by checking the number of submitted exceptions versus the number of submitted restrictions.

@jpeg729
Copy link
Contributor

jpeg729 commented Feb 23, 2014

How about only submitting functions marked used?
And if a function is marked used & on-demand we could take exceptions into account as you propose.

M66B pushed a commit that referenced this issue Feb 24, 2014
@M66B
Copy link
Owner

M66B commented Feb 24, 2014

We cannot be sure if the function wasn't used so far, it will never be used.
Better safe than sorry here.

@jpeg729
Copy link
Contributor

jpeg729 commented Feb 24, 2014

Fetching could start by applying the template and then tweaking according to the received data.
Just an idea, but I've got the feeling that the usage data properly combined with the restriction data could be used to good effect.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

4 participants