Skip to content
This repository has been archived by the owner on Sep 6, 2019. It is now read-only.

Commit

Permalink
Updated to do
Browse files Browse the repository at this point in the history
  • Loading branch information
M66B committed Jan 20, 2014
1 parent f7ff417 commit bd11152
Showing 1 changed file with 1 addition and 0 deletions.
1 change: 1 addition & 0 deletions TODO.md
View file
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,7 @@ For interested developers:
* Only show installed applications for secondary users
* Only allow restrictions for applications installed by secondary users
* Only import/export for applications installed by secondary users
* Document XPrivacy navigation (menu's, presses, long presses) on GitHub

* Accessibility: *android:labelFor="..."*
* Secure usage data
Expand Down

27 comments on commit bd11152

@wbedard
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you use some help with this? I'm not prepared to use "git" to contribute via pull request (I just hate git too much...) but I can provide you with "baseline" content and tweak it up if requested.

@M66B
Copy link
Owner

@M66B M66B commented on bd11152 Jan 20, 2014

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, please, your help is more than welcome, so I can concentrate on other things.
My idea was to briefly document all possible actions, menu's, icon, tabs, short press, long press, etc for all activities:

  • Application list
  • Application details view
  • Usage view

This will help new users to find things.

@wbedard
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK, I'll start work on it. I assume that a notional "deadline" would be to support the stable 2.0 release but it would help to attach a rough date for me to shoot for. That will help me scope how much detail I put in. Additionally, is this documentation only going to be available via GitHub? Do you have designs to eventually farm it out for translation and integrate it into the app?

@M66B
Copy link
Owner

@M66B M66B commented on bd11152 Jan 20, 2014

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This project has no deadlines, so don't worry about time frames.

For now it will be on GitHub only.
I had planned it below Usage:
https://github.com/M66B/XPrivacy#usage

There is still an open issue to document more things, in app when possible.
#838

@wbedard
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK. I'll rough something up this week based on the current 1.99.x release. I'll drop the documentation into a post to this issue around Friday or so.

@M66B
Copy link
Owner

@M66B M66B commented on bd11152 Jan 20, 2014

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you want, contact me through this form to test the new update services that takes care of migrating, randomization and upgrading, with progress notifications: http://forum.faircode.eu/contact/

You will get a preview on the fixes/features listed for the next release:
https://github.com/M66B/XPrivacy/blob/master/CHANGELOG.md

@wbedard
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am happy to test for you. By way of clarification though, am I using the contact page to send you a message or what...it's a bit unclear to me what you are requesting I do!

@M66B
Copy link
Owner

@M66B M66B commented on bd11152 Jan 20, 2014

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't want to publish my e-mail address in public, so we need to get in touch in some way.
You can use the contact form, or my PM if you know that or XDA PM or maybe even telepathy ;-)

@M66B
Copy link
Owner

@M66B M66B commented on bd11152 Jan 20, 2014

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lets keep it simple, here is a link: http://d-h.st/SYl ;-)

@wbedard
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK that's what was throwing me since I was expecting a link, since that's what you normally do!

@wbedard
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

BTW, is it your recommendation that I still bring XP to the foreground as soon as possible in order to avoid a lowmem kill of the service or do you want me to test improvements to that aspect of the migration?

@M66B
Copy link
Owner

@M66B M66B commented on bd11152 Jan 20, 2014

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unless the memory is extremely low, this should not be necessary anymore.
The migration runs in a foreground service, which is only killed in extreme circumstances.
There is one notably exception: if you have more than three foreground services running, Android might kill some.
Foreground services always have an icon in the notification bar, this is an Android requirement.

@wbedard
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmmm, good to know. While I tend to have 400MB+ available memory after boot+settle, I also have 5 applications that I "choose" to display notification icons. I'm not sure if they all qualify as services (probably do though...) but I'll give it a shot without bringing XP to the foreground. If it doesn't work out, I'll try the fallback scheme. Either way, I'm looking fwd to seeing the feedback from the migration service!

@M66B
Copy link
Owner

@M66B M66B commented on bd11152 Jan 20, 2014

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe it is good to know that the old restriction files will be used until the migration complete.
So, if the migration fails or was aborted, just reboot your device to continue the migration.

@wbedard
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rgr that!

@wbedard
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Migration started just about now...:>)

W/XPrivacy( 3890): Migration
W/XPrivacy( 3890): Migrating /data/data/biz.bokhorst.xprivacy/shared_prefs/biz.bokhorst.xprivacy.provider.settings.xml
W/XPrivacy( 3890): Migrate setting=ID.10088 uid=10088 name=ID value=110885F83D300E54
...

@wbedard
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Migration notification icon showing 0% but logcat shows it's working through the settings.
...
Oooo, there it is...lowmem killed it. Restarting and will bring XP to the foreground.

@wbedard
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Device rebooted, migration restarted, XP in the foreground.
When I started XP, the settings for theme or randomize were still not set.
BTW, I did notice that the "*provider.settings.xml" was the first file processed on the previous migration run.

@wbedard
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Device has settled down, XP migration service icon shows at 6%...

@jpeg729
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@wbedard you can actually create a pull request only using the website. Just find the readme on M66B's github, (here) and click the EDIT button. It will automatically fork the project, allow you to edit the file, and propose the changes, all painlessly from within the browser. And what's more, you get to preview the changes so you can tell if your formatting is correct.

@wbedard
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the tip. Actually, I have done a lot of work on the GitHub site using that approach. However, eventually, it seems there's something you can't do (i.e. resolve merge conflict, etc) without having a local clone of the project. I'll give it a shot, though, and see how it goes!

@wbedard
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And we're done!
(any reason the icon disappears without indicating "Migration Complete"?)
Restarting the XP app shows that theme and randomization settings migrated over.
...
W/XPrivacy( 4011): Migration complete
W/XPrivacy( 4011): Randomization
W/XPrivacy( 4011): Randomization complete

@M66B
Copy link
Owner

@M66B M66B commented on bd11152 Jan 21, 2014

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have just added the message 'migration complete'.
It appeared that the foreground service was prematurely stopped, so I have fixed that too.
Thanks for testing!

@wbedard
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No problem, glad to help. Your post caused me to look over the "normal" XP data directory. All the app restriction XML files were renamed but none of the usage XML files were. Was this an oversight, by design, etc.? Is usage data being maintained in the database?

@M66B
Copy link
Owner

@M66B M66B commented on bd11152 Jan 21, 2014

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The usage data is registered into the new database.
I have chosen not to put time in migrating the existing usage data, that is why the usage data files are left untouched.

@wbedard
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Understood. So those files can be deleted to avoid them being carried fwd in future TiBkp backup/restore operations?

@M66B
Copy link
Owner

@M66B M66B commented on bd11152 Jan 21, 2014

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes.

Please sign in to comment.