Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed multiplatform compatibility when inherit flag is present. #23

Closed
wants to merge 1 commit into from
Closed

Fixed multiplatform compatibility when inherit flag is present. #23

wants to merge 1 commit into from

Conversation

hectormenendez
Copy link
Contributor

@hectormenendez hectormenendez commented Aug 11, 2016

Tested on windows 10 and MacOS sierra. Node v6.2. This is a followup of #22


This change is Reviewable

@M-Zuber
Copy link
Owner

M-Zuber commented Aug 15, 2016

Does ['pipe', 'inherit', 'inherit'] not work on windows, instead of using customFds?
Will try and play with this tomorrow.

@hectormenendez
Copy link
Contributor Author

I tried several combinations with stdio and nothing worked for me on windows, just customFds.

@M-Zuber
Copy link
Owner

M-Zuber commented Aug 23, 2016

@domarmstrong I am trying to work this out, any chance you could send me a minimized version of you setup with 'debug' for me to test?

@M-Zuber
Copy link
Owner

M-Zuber commented Nov 14, 2016

@hectormenendez with

npm -v -> 3.9.5
node -v -> 6.2.2

['pipe', 'inherit', 'inherit'] works on windows.

Have a bit more to look into, but hopefully that is the only change needed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants