-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add type check for compatible #4
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FeelyChau
force-pushed
the
feat/type-test-for-compatible
branch
from
December 4, 2023 10:05
43719aa
to
1aedb08
Compare
yorkie
requested changes
Dec 4, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
整体上不错,提了几个建议。
FeelyChau
force-pushed
the
feat/type-test-for-compatible
branch
from
December 6, 2023 03:34
1aedb08
to
f9a70a2
Compare
FeelyChau
force-pushed
the
feat/type-test-for-compatible
branch
2 times, most recently
from
December 6, 2023 03:50
498d683
to
648be7d
Compare
yorkie
requested changes
Dec 6, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- 需要把
as unknown
去掉并使用正确的类型 - 去掉 "type.utils.d.ts"
FeelyChau
force-pushed
the
feat/type-test-for-compatible
branch
2 times, most recently
from
December 6, 2023 14:26
f939731
to
2e72819
Compare
FeelyChau
force-pushed
the
feat/type-test-for-compatible
branch
from
December 6, 2023 14:29
2e72819
to
be208b4
Compare
yorkie
approved these changes
Dec 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.