Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add type check for compatible #4

Merged
merged 1 commit into from
Dec 7, 2023
Merged

Conversation

FeelyChau
Copy link
Collaborator

No description provided.

@FeelyChau FeelyChau marked this pull request as draft December 4, 2023 10:05
@FeelyChau FeelyChau force-pushed the feat/type-test-for-compatible branch from 43719aa to 1aedb08 Compare December 4, 2023 10:05
Copy link
Contributor

@yorkie yorkie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

整体上不错,提了几个建议。

src/living/nodes/Node.test.ts Outdated Show resolved Hide resolved
src/living/nodes/Node.ts Show resolved Hide resolved
src/type.utils.d.ts Outdated Show resolved Hide resolved
@FeelyChau FeelyChau force-pushed the feat/type-test-for-compatible branch from 1aedb08 to f9a70a2 Compare December 6, 2023 03:34
@FeelyChau FeelyChau marked this pull request as ready for review December 6, 2023 03:34
@FeelyChau FeelyChau force-pushed the feat/type-test-for-compatible branch 2 times, most recently from 498d683 to 648be7d Compare December 6, 2023 03:50
Copy link
Contributor

@yorkie yorkie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. 需要把 as unknown 去掉并使用正确的类型
  2. 去掉 "type.utils.d.ts"

src/living/compatible.test.ts Outdated Show resolved Hide resolved
src/living/compatible.test.ts Show resolved Hide resolved
src/living/nodes/ChildNode.ts Outdated Show resolved Hide resolved
src/living/nodes/ChildNode.ts Outdated Show resolved Hide resolved
src/living/nodes/ChildNode.ts Outdated Show resolved Hide resolved
src/type.utils.d.ts Outdated Show resolved Hide resolved
src/living/nodes/ChildNode.ts Outdated Show resolved Hide resolved
@FeelyChau FeelyChau force-pushed the feat/type-test-for-compatible branch 2 times, most recently from f939731 to 2e72819 Compare December 6, 2023 14:26
@FeelyChau FeelyChau force-pushed the feat/type-test-for-compatible branch from 2e72819 to be208b4 Compare December 6, 2023 14:29
@yorkie yorkie merged commit 743c983 into main Dec 7, 2023
6 checks passed
@yorkie yorkie deleted the feat/type-test-for-compatible branch December 7, 2023 07:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants