Skip to content

Commit

Permalink
bootstrap.sh: Fix more SC2086 warnings
Browse files Browse the repository at this point in the history
Just quote the things

Shellcheck warnings were:

    In bootstrap-scripts/bootstrap.sh line 128:
      kill -TERM $timeout_loop_PID
                 ^---------------^ SC2086 (info): Double quote to prevent globbing and word splitting.

    Did you mean:
      kill -TERM "$timeout_loop_PID"

    In bootstrap-scripts/bootstrap.sh line 185:
        rustup default stable-${machine}-apple-darwin
                              ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting.

    Did you mean:
        rustup default stable-"${machine}"-apple-darwin
  • Loading branch information
trinitronx committed Jul 17, 2024
1 parent d2b40f6 commit ce76d99
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions bootstrap-scripts/bootstrap.sh
Original file line number Diff line number Diff line change
Expand Up @@ -125,7 +125,7 @@ prevent_sudo_timeout() {
# shellcheck disable=SC2317
kill_timeout_loop() {
echo "Killing $timeout_loop_PID due to trap"
kill -TERM $timeout_loop_PID
kill -TERM "$timeout_loop_PID"
sudo -K
}
trap kill_timeout_loop EXIT HUP TSTP QUIT SEGV TERM INT ABRT # trap all common terminate signals
Expand Down Expand Up @@ -182,7 +182,7 @@ function rvm_set_compile_opts() {

if [[ "$RVM_ENABLE_YJIT" == "1" ]]; then
CONFIGURE_ARGS="${CONFIGURE_ARGS} --enable-yjit"
rustup default stable-${machine}-apple-darwin
rustup default "stable-${machine}-apple-darwin"
fi
if [[ "$RVM_WITH_JEMALLOC" == "1" ]]; then
CONFIGURE_ARGS="${CONFIGURE_ARGS} --with-jemalloc"
Expand Down

0 comments on commit ce76d99

Please sign in to comment.